Fix denylist spam can't be unchecked

[truongwp]

This PR:

• Fixes the issue with denylist checkbox that can't be unchecked.
• Hide Disallowed words and Allowed words settings if denylist checkbox is unchecked.
• Moved recent spam words outside of <p> to fix HTML problem (<div> inside <p>).

[coderabbitai]

Walkthrough

The changes update the FrmSettings class to process the 'denylist_check' setting, ensuring it is stored based on user input. Additionally, the spam denylist settings UI is enhanced by conditionally displaying custom allowed and disallowed words fields only when denylist checking is enabled.

Changes

File(s)	Change Summary
classes/models/FrmSettings.php	Modified the update_settings() method to include 'denylist_check' in the processed checkbox options.
classes/views/frm-settings/captcha/captcha.php	Wrapped custom allowed/disallowed words fields in a container shown only if denylist checking is on.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SettingsUI
    participant FrmSettings

    User->>SettingsUI: Toggle "Check denylist data" checkbox
    SettingsUI->>SettingsUI: Show/hide denylist fields dynamically

    User->>SettingsUI: Submit settings form
    SettingsUI->>FrmSettings: Pass form data (including frm_denylist_check)
    FrmSettings->>FrmSettings: update_settings() processes 'denylist_check'
    FrmSettings-->>SettingsUI: Save updated settings

Loading

Possibly related PRs

• Denylist spam check improvements #2361: Adds the 'denylist_check' property and default value in FrmSettings, directly related to this PR's processing of the same setting.
• Denylist spam performance improvement #2357: Optimizes FrmSpamCheckDenylist to skip field fetching when denylist spam checking is disabled, relating to the same feature area.

Suggested labels

run analysis, run tests, action: needs qa

Suggested reviewers

• Crabcyborg

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

---

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fd264c4 and 291b1d0.

📒 Files selected for processing (2)

• classes/models/FrmSettings.php (1 hunks)
• classes/views/frm-settings/captcha/captcha.php (2 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

classes/views/frm-settings/captcha/captcha.php (1)

classes/helpers/FrmAppHelper.php (4)

• checked (2227-2231)
• FrmAppHelper (6-4600)
• tooltip_icon (4526-4538)
• esc_textarea (2324-2336)

🔇 Additional comments (3)

classes/models/FrmSettings.php (1)

432-432: Good fix for the toggle functionality.

This change adds the denylist_check property to the list of checkboxes processed in the update_settings method, ensuring the property will be properly toggled based on user input. This fixes the issue where the denylist checkbox couldn't be unchecked.

classes/views/frm-settings/captcha/captcha.php (2)

124-124: Excellent addition of toggle functionality.

Adding the data-toggleclass attribute enables JavaScript to automatically show/hide the denylist settings when the checkbox state changes, which improves the user experience.

---

129-157: Well-structured container for conditional display.

This change properly groups the denylist settings into a container that can be toggled based on the checkbox state. The implementation:

1. Wraps related settings in a semantic container
2. Initially hides settings when denylist is disabled
3. Properly organizes the disallowed and allowed words fields
4. Fixes the HTML structure by ensuring the spam words notification is properly contained

This addresses both the toggling functionality and the HTML structural issue mentioned in the PR objectives.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Crabcyborg]

Thank you @truongwp!

🚀