Skip to content

Fix denylist spam can't be unchecked #2370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Crabcyborg merged 2 commits into from
May 20, 2025
Merged

Fix denylist spam can't be unchecked #2370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5b04be
Fix denylist checkbox can't be unchecked
truongwp May 19, 2025
291b1d0
Hide denylist words if it is disabled
truongwp May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions classes/models/FrmSettings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,6 +429,7 @@ private function update_settings( $params ) {
'summary_emails',
'honeypot',
'wp_spam_check',
'denylist_check',
);
foreach ( $checkboxes as $set ) {
$this->$set = isset( $params[ 'frm_' . $set ] ) ? absint( $params[ 'frm_' . $set ] ) : 0;
Expand Down
33 changes: 18 additions & 15 deletions classes/views/frm-settings/captcha/captcha.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,25 +121,28 @@

<p>
<label>
<input type="checkbox" name="frm_denylist_check" value="1" <?php checked( $frm_settings->denylist_check, 1 ); ?> />
<input type="checkbox" name="frm_denylist_check" data-toggleclass="frm-denylist-settings" value="1" <?php checked( $frm_settings->denylist_check, 1 ); ?> />
<?php esc_html_e( 'Check denylist data to validate for spam', 'formidable' ); ?>
</label>
</p>

<p>
<label for="frm-disallowed-words">
<?php esc_html_e( 'Custom disallowed words', 'formidable' ); ?>
<?php FrmAppHelper::tooltip_icon( __( 'Each word is on one line.', 'formidable' ), array( 'data-container' => 'body' ) ); ?>
</label>
<textarea id="frm-disallowed-words" name="frm_disallowed_words"><?php echo esc_textarea( $frm_settings->disallowed_words ); ?></textarea>
</p>
<div class="frm-denylist-settings <?php echo $frm_settings->denylist_check ? '' : 'frm_hidden'; ?>">
<p>
<label for="frm-disallowed-words">
<?php esc_html_e( 'Custom disallowed words', 'formidable' ); ?>
<?php FrmAppHelper::tooltip_icon( __( 'Each word is on one line.', 'formidable' ), array( 'data-container' => 'body' ) ); ?>
</label>
<textarea id="frm-disallowed-words" name="frm_disallowed_words"><?php echo esc_textarea( $frm_settings->disallowed_words ); ?></textarea>
</p>

<p>
<label for="frm-allowed-words">
<?php esc_html_e( 'Custom allowed words', 'formidable' ); ?>
<?php FrmAppHelper::tooltip_icon( __( 'Each word is on one line.', 'formidable' ), array( 'data-container' => 'body' ) ); ?>
</label>
<textarea id="frm-allowed-words" name="frm_allowed_words"><?php echo esc_textarea( $frm_settings->allowed_words ); ?></textarea>
</p>

<p>
<label for="frm-allowed-words">
<?php esc_html_e( 'Custom allowed words', 'formidable' ); ?>
<?php FrmAppHelper::tooltip_icon( __( 'Each word is on one line.', 'formidable' ), array( 'data-container' => 'body' ) ); ?>
</label>
<textarea id="frm-allowed-words" name="frm_allowed_words"><?php echo esc_textarea( $frm_settings->allowed_words ); ?></textarea>
<?php
$transient = get_transient( 'frm_recent_spam_detected' );
if ( ! empty( $transient ) ) {
Expand All @@ -151,4 +154,4 @@
<?php
}
?>
</p>
</div><!-- End .frm-denylist-settings -->
Loading