fix failing test

[lauramekaj1]

No description provided.

[coderabbitai]

Walkthrough

Adds a new allowed banner text ("Get the Deal") to the upgrade-link detection logic in the Cypress test so it follows the existing upgrade navigation path. No other logic or exports changed.

Changes

Cohort / File(s)	Summary of Changes
Cypress E2E: Forms upgrade banner handling tests/cypress/e2e/Forms/formPageDataValidation.cy.js	Extended banner text check to include "Get the Deal" alongside existing texts and regex, routing it through the same cy.origin/visit/header validation flow. No other branches modified.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Fix test to handle dynamic h1 text on formidableforms.com #2083 — Also updates the same test’s post-upgrade header checks to accept multiple texts.
• Update banner CTA Check (e2e) #2351 — Adjusts banner CTA text handling in the same file, adding additional text patterns.
• handle cross-origin redirect in Cypress tests #2387 — Modifies upgrade banner detection/handling using cy.origin and explicit visit in the same test.

Suggested reviewers

• Crabcyborg

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-failing-test

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (4)

tests/cypress/e2e/Forms/formPageDataValidation.cy.js (4)

22-23: Harden banner-text detection (case-insensitive + more robust regex).

Current checks are case-sensitive and can flake if marketing adjusts capitalization/spacing. Minimal tweak below keeps your new string while reducing brittleness.

-                if (href && (text.includes('upgrading to PRO') || text.includes( 'Get 60% Off Pro!' ) || text.includes('Get the Deal') || text.match(/GET \d+% OFF|SAVE \d+%/))) {
+                const lower = text.toLowerCase();
+                if (href && (lower.includes('upgrading to pro') || lower.includes('get 60% off pro!') || lower.includes('get the deal') || /(?:get\s+\d+%\s+off|save\s+\d+%)/i.test(text))) {

---

17-21: Avoid multi-element pitfalls: operate on a single link.

cy.get() may match multiple anchors; $el.text() would concatenate text and attr('href') comes from the first element only. Explicitly narrow to the first match and assert href presence to prevent accidental false positives/negatives.

-		cy.get('.frm-upgrade-bar .frm-upgrade-bar-inner > a, #frm_sale_banner a:not(.dismiss)')
-			.then(($el) => {
+		cy.get('.frm-upgrade-bar .frm-upgrade-bar-inner > a, #frm_sale_banner a:not(.dismiss)')
+            .first()
+            .should('have.attr', 'href')
+			.then(($el) => {

---

25-27: Trim heading text before comparison.

Minor resiliency improvement against stray whitespace or newlines around h1.

-						cy.get('h1').should(($h1) => {
-							const headingText = $h1.text();
+						cy.get('h1').should(($h1) => {
+							const headingText = $h1.text().trim();

---

37-37: Improve failure diagnostics with href echo.

Including href in the thrown error accelerates triage when banner copy or link targets change.

-            throw new Error(`Unexpected banner text or missing href: "${text}"`);
+            throw new Error(`Unexpected banner or missing href: text="${text}", href="${href}"`);

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 6f91de1 and bb7339c.

📒 Files selected for processing (1)

• tests/cypress/e2e/Forms/formPageDataValidation.cy.js (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

tests/cypress/e2e/Forms/formPageDataValidation.cy.js (1)

js/formidable_admin.js (1)

• href (10881-10881)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)

• GitHub Check: PHP 7.4 tests in WP trunk
• GitHub Check: PHP 8 tests in WP trunk
• GitHub Check: Run PHP Syntax inspection (8.3)
• GitHub Check: Cypress
• GitHub Check: PHP 8 tests in WP trunk
• GitHub Check: PHP 7.4 tests in WP trunk
• GitHub Check: Cypress
• GitHub Check: Cypress
• GitHub Check: PHP 8 tests in WP trunk
• GitHub Check: PHP 7.4 tests in WP trunk
• GitHub Check: Run PHP Syntax inspection (8.3)

🔇 Additional comments (1)

tests/cypress/e2e/Forms/formPageDataValidation.cy.js (1)

22-22: LGTM: allowlist extended to include “Get the Deal”.

This aligns with the PR goal to fix the failing test caused by new banner copy. Change is scoped and safe.

[lauramekaj1]

@Crabcyborg
The failing test has been resolved. I updated the test to account for the new banner variation.

[Crabcyborg]

Thank you @lauramekaj1!

🙌