Add some e2e test substrings for cyber monday

[Crabcyborg]

No description provided.

[coderabbitai]

Walkthrough

Adds "Cyber Monday Deals" to accepted upgrade banner/CTA texts in two Cypress tests, expanding the set of valid strings used in assertions without altering test logic or control flow.

Changes

Cohort / File(s)	Change Summary
Upgrade CTA & banner text validations tests/cypress/e2e/Entries/EntriesPageDataValidations.cy.js, tests/cypress/e2e/Forms/formPageDataValidation.cy.js	Appends the string "Cyber Monday Deals" to existing lists of accepted upgrade CTA/banner texts used in assertions that validate upgrade messages on entries and form pages.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Review primarily focused on the two test files listed above to ensure the new string is correctly added in all relevant assertions and that no typos/escaping issues were introduced.

Possibly related PRs

• validate elements and data of entries of submitted forms #1917 — Also updates Entries test assertions to accept additional upgrade message text.
• Add e2e exceptions for black friday #2587 — Expands allowed upgrade-banner texts in the same tests (adds different sale text variants).
• fix failing test #2471 — Modifies formPageDataValidation.cy.js to add extra allowed banner substrings.

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	No pull request description was provided by the author, making it impossible to assess whether a description is related to the changeset.	Add a pull request description that explains the purpose and context of adding the 'Cyber Monday Deals' test substrings.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: adding e2e test substrings related to 'Cyber Monday' to the test files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch add_some_e2e_test_substrings

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 77803a5 and 573025b.

📒 Files selected for processing (1)

• tests/cypress/e2e/Forms/formPageDataValidation.cy.js (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• tests/cypress/e2e/Forms/formPageDataValidation.cy.js

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Cypress
• GitHub Check: PHP 7.4 tests in WP trunk
• GitHub Check: PHP 8 tests in WP trunk

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

tests/cypress/e2e/Forms/formPageDataValidation.cy.js (1)

27-27: LGTM! Promotional string added correctly.

The addition of 'Cyber Monday Deals' to the accepted upgrade banner substrings is correctly implemented and consistent with existing entries.

Since this is time-sensitive promotional content, consider creating a tracking issue to remove this string after Cyber Monday ends. Would you like me to help draft that issue?

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c076266 and 77803a5.

📒 Files selected for processing (2)

• tests/cypress/e2e/Entries/EntriesPageDataValidations.cy.js (1 hunks)
• tests/cypress/e2e/Forms/formPageDataValidation.cy.js (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Cypress
• GitHub Check: PHP 8 tests in WP trunk
• GitHub Check: PHP 7.4 tests in WP trunk

🔇 Additional comments (1)

tests/cypress/e2e/Entries/EntriesPageDataValidations.cy.js (1)

57-57: LGTM! Consistent with the Forms test update.

The addition of 'Cyber Monday Deals' to the expected upgrade CTA texts is correctly implemented and aligns with the parallel change in formPageDataValidation.cy.js.