Drop old deprecated visible/invisible JS global functions

[Crabcyborg]

Related issue https://github.com/Strategy11/formidable-pro/issues/5002, dropping the last references to jQuery().css().

These have been deprecated for a year, and shouldn't really be used in any custom code.

[coderabbitai]

Walkthrough

Removed two deprecated public API methods (invisible(classes) and visible(classes)) from the frmFrontFormJS object in js/formidable.js. These methods previously logged deprecation warnings and applied jQuery-based visibility changes. No replacement logic is introduced.

Changes

Cohort / File(s)	Summary
Deprecated API Methods Removal js/formidable.js	Removed invisible(classes) and visible(classes) methods from the frmFrontFormJS public API exposure

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Verify that the removed methods are not referenced elsewhere in the codebase (especially templates or inline scripts)
• Confirm that any existing tests related to these methods are updated or removed
• Ensure the deprecation warning removal aligns with version release notes

Possibly related PRs

• Deprecate old JS functions #2153 — Initially added deprecation warnings to invisible(classes) and visible(classes) methods; this PR completes the removal cycle
• Drop deprecated savingDraft function #1908 — Previously removed other deprecated methods from the same frmFrontFormJS exported object

Suggested labels

run analysis, run tests

Suggested reviewers

• shervElmi

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The pull request title clearly and concisely describes the main change: removing deprecated visible/invisible JS global functions.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check	✅ Passed	The pull request description is clearly related to the changeset, explicitly mentioning the deprecated functions being removed and providing context about deprecation.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch drop_old_deprecated_visible_invisible_js_global_functions

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 26.30%. Comparing base (ef5a7ff) to head (223192e).
⚠️ Report is 264 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #2629      +/-   ##
============================================
- Coverage     26.38%   26.30%   -0.09%     
- Complexity     8852     8853       +1     
============================================
  Files           144      144              
  Lines         29932    29934       +2     
============================================
- Hits           7899     7873      -26     
- Misses        22033    22061      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.