Deprecate old JS functions

[Crabcyborg]

I could only find references to this in old Lite code (pre 3.0). It looks like it was really used to toggle elements in the back end.

I think we should be good to remove these functions. For now, I'm deprecating them just in case.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces two new methods, invisible and visible, to the frmFrontForm object in js/formidable.js. Both methods are marked as deprecated and are designed to manipulate the CSS visibility property of elements. Each method includes a console warning regarding its deprecated status. The existing frmRecaptcha function remains unchanged but is referenced in relation to the new methods, indicating a potential connection in usage.

Changes

File	Change Summary
js/formidable.js	Added deprecated methods invisible(classes) and visible(classes) to frmFrontForm. Each method sets the CSS visibility property and includes a console warning about deprecation. The frmRecaptcha function is referenced in the context of the new methods.

Possibly related PRs

• Stop using jQuery for required field validation #2109: This PR modifies the validateForm function within js/formidable.js, which is related to the frmFrontForm object where the new invisible and visible methods were added in the main PR.
• Remove some code that does nothing #2152: This PR updates the getFormErrors function in js/formidable.js, also part of the frmFrontForm object, focusing on refining form processing logic.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between b43d7b2 and d295544.

📒 Files selected for processing (1)

• js/formidable.js (1 hunks)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (1)

js/formidable.js (1)

1965-1979: Consider using CSS classes instead of inline styles.

For better maintainability and performance, consider:

1. Using CSS classes instead of inline styles
2. Adding migration guidance in the deprecation notice to help users transition

Example implementation:

 invisible: function( classes ) {
     console.warn(
-        'DEPRECATED: function frmFrontForm.invisible in vx.x'
+        'DEPRECATED: function frmFrontForm.invisible in v6.0. Will be removed in v7.0.\n' +
+        'Migration guide: Use CSS classes instead. Add .frm-hidden { visibility: hidden; } ' +
+        'to your CSS and use jQuery(element).addClass("frm-hidden")'
     );
-    jQuery( classes ).css( 'visibility', 'hidden' );
+    jQuery( classes ).addClass( 'frm-hidden' );
 },

🧰 Tools

🪛 eslint

[error] 1965-1967: Missing JSDoc @param "classes" declaration.

(jsdoc/require-param)

---

[error] 1974-1976: Missing JSDoc @param "classes" declaration.

(jsdoc/require-param)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 0d17044 and b43d7b2.

📒 Files selected for processing (1)

• js/formidable.js (1 hunks)

🧰 Additional context used

🪛 eslint

js/formidable.js

[error] 1965-1967: Missing JSDoc @param "classes" declaration.

(jsdoc/require-param)

---

[error] 1974-1976: Missing JSDoc @param "classes" declaration.

(jsdoc/require-param)