Exclude bg image id from style output vars

[Crabcyborg]

No description provided.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Extracts hard-coded CSS variable exclusion logic from the output_vars method into a new private static helper method get_style_keys_to_remove_from_output_vars(). The helper centralizes key management and adds bg_image_id to the excluded set, while the public output flow and validation remain unchanged.

Changes

Cohort / File(s)	Summary
CSS Variable Exclusion Refactoring classes/helpers/FrmStylesHelper.php	Centralizes hard-coded CSS variable exclusion keys by extracting them into a new private static helper method; adds bg_image_id to the excluded keys set

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Verify that bg_image_id addition to exclusions is intentional and correct
• Ensure the new helper method properly encapsulates all previously hard-coded exclusion keys
• Confirm no unintended changes to the public output_vars behavior

Possibly related PRs

• Do not output invalid css vars #2296: Both PRs modify FrmStylesHelper::output_vars to change which CSS variable keys are excluded from output.
• Stop outputting field shape type as css var #2328: Both PRs alter the set of CSS variable keys excluded in FrmStylesHelper.php (this PR centralizes the logic and adds bg_image_id; retrieved PR adds field_shape_type).

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch exclude_bg_image_id_from_style_output_vars

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fb0e39e and d8a59a9.

📒 Files selected for processing (1)

• classes/helpers/FrmStylesHelper.php (2 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}