Skip to content

Exclude bg image id from style output vars #2651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Crabcyborg merged 2 commits into from
Dec 12, 2025
Merged

Exclude bg image id from style output vars #2651

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5160b0
Exclude bg image id from style output vars
Crabcyborg Dec 12, 2025
d8a59a9
Add a function description
Crabcyborg Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 30 additions & 2 deletions classes/helpers/FrmStylesHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,8 +484,7 @@ public static function output_vars( $settings, $defaults = array(), $vars = arra
$vars = self::get_css_vars( array_keys( $settings ) );
}

$remove = array( 'remove_box_shadow', 'remove_box_shadow_active', 'theme_css', 'theme_name', 'theme_selector', 'important_style', 'submit_style', 'collapse_icon', 'center_form', 'custom_css', 'style_class', 'submit_bg_img', 'change_margin', 'repeat_icon', 'use_base_font_size', 'field_shape_type' );
$vars = array_diff( $vars, $remove );
$vars = array_diff( $vars, self::get_style_keys_to_remove_from_output_vars() );

foreach ( $vars as $var ) {
if ( ! isset( $settings[ $var ] ) || ! self::css_key_is_valid( $var ) ) {
Expand All @@ -504,6 +503,35 @@ public static function output_vars( $settings, $defaults = array(), $vars = arra
}
}

/**
* None of these style settings are used as CSS variables, so we want to exclude them to keep the CSS output clean.
*
* @since x.x
*
* @return array<string>
*/
private static function get_style_keys_to_remove_from_output_vars() {
return array(
'remove_box_shadow',
'remove_box_shadow_active',
'theme_css',
'theme_name',
'theme_selector',
'important_style',
'submit_style',
'collapse_icon',
'center_form',
'custom_css',
'style_class',
'submit_bg_img',
'change_margin',
'repeat_icon',
'use_base_font_size',
'field_shape_type',
'bg_image_id',
);
}

/**
* Check if a CSS variable setting is not blank, doesn't match the default, and doesn't include invalid substrings.
*
Expand Down