Improve redundant paren sniff and remove is_array checks before stric…

[Crabcyborg]

…t array comparison

Summary by CodeRabbit

• New Features

  • Added a code analysis rule that detects and auto-fixes redundant array-check patterns.

• Refactor

  • Simplified conditional logic in field entry handling and styling.
  • Removed unnecessary parentheses from comparison checks for clearer logic.

• Chores

  • Improved code-analysis tooling to provide safer, atomic fixes and broader redundancy detection.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

Adds a new PHPCS sniff that detects and auto-fixes redundant is_array(...) checks before empty-array comparisons, updates the ruleset to register it, enhances redundant-parentheses detection with a helper, and applies three small code edits removing redundant checks/parentheses.

Changes

Cohort / File(s)	Summary
New PHPCS Sniff phpcs-sniffs/Formidable/Sniffs/CodeAnalysis/RedundantIsArrayBeforeEmptyArrayCheckSniff.php	New 322-line sniff implementing register() and process() plus helpers to detect patterns like is_array($v) && $v === array() / is_array($v) && array() === $v, report fixable errors, and remove the redundant is_array(...) && via fixer.
Sniff Enhancement phpcs-sniffs/Formidable/Sniffs/CodeAnalysis/RedundantParenthesesSniff.php	Added private isSimpleComparisonExpression() helper and integrated it into isRedundantNegatedFunctionCall() to treat simple comparison expressions as redundant-parentheses candidates.
Rule Registration phpcs-sniffs/Formidable/ruleset.xml	Added Formidable.CodeAnalysis.RedundantIsArrayBeforeEmptyArrayCheck to the Code Analysis ruleset.
Small Source Edits classes/models/FrmEntry.php, classes/models/FrmStyle.php, classes/views/frm-fields/front-end/radio-field.php	Three one-line edits: removed redundant is_array() check in FrmEntry.php and simplified parenthesis in conditional checks in FrmStyle.php and radio-field.php.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• Add new sniff to simplify count equals 0 checks #2844 — Modifies convert_values_to_their_saved_value in classes/models/FrmEntry.php; overlaps the same change to empty-array handling.
• Move formidable sniffs to separate ruleset file #2801 — Changes PHPCS sniffs/ruleset entries; related to adding/updating CodeAnalysis sniffs and ruleset registration.
• Improve redundant parantheses sniff #2793 — Updates RedundantParenthesesSniff; shares changes in redundant-parentheses detection logic.

Poem

🐰 I hopped through tokens, sniffed a line,

"is_array? nah — the array check'll shine!"
I nibbled parentheses, pruned a bit tidy,
Now code hops light and bankers bite kindly. 🥕✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main changes: improving the redundant parentheses sniff and removing redundant is_array checks before strict array comparisons across multiple files.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🤖 Fix all issues with AI agents

In
`@phpcs-sniffs/Formidable/Sniffs/CodeAnalysis/RedundantIsArrayBeforeEmptyArrayCheckSniff.php`:
- Around line 45-105: The sniff currently matches any T_STRING with content
"is_array" including method/namespace usages; before proceeding in process( File
$phpcsFile, $stackPtr ) add a guard that fetches the previous non-whitespace
token (use $phpcsFile->findPrevious with $stackPtr - 1) and returns early if
that token code is T_OBJECT_OPERATOR, T_DOUBLE_COLON or T_NS_SEPARATOR (and also
return if previous token is T_STRING followed by T_NS_SEPARATOR to cover
namespaced qualifiers) so only the global function call is handled; keep the
rest of the logic unchanged and reference $stackPtr, $tokens and process() when
implementing the check.

In `@phpcs-sniffs/Formidable/Sniffs/CodeAnalysis/RedundantParenthesesSniff.php`:
- Around line 235-242: The logical operator detection in
RedundantParenthesesSniff.php is missing T_LOGICAL_XOR, so add T_LOGICAL_XOR to
the in_array list that increments $logicalCount (the block that checks for
T_BOOLEAN_AND, T_BOOLEAN_OR, T_LOGICAL_AND, T_LOGICAL_OR) to ensure `xor` is
treated as a logical operator and prevents unsafe removal of parentheses in
methods handling redundant parentheses detection.

🧹 Nitpick comments (1)

phpcs-sniffs/Formidable/Sniffs/CodeAnalysis/RedundantIsArrayBeforeEmptyArrayCheckSniff.php (1)

300-319: Drop unused parameters in reportAndFix to satisfy PHPMD.
$isArrayEnd and $varContent are unused; tightening the signature removes static-analysis noise.

♻️ Proposed refactor

-				$this->reportAndFix( $phpcsFile, $stackPtr, $closeParen, $afterClose, $varContent );
+				$this->reportAndFix( $phpcsFile, $stackPtr, $afterClose );
@@
-			$this->reportAndFix( $phpcsFile, $stackPtr, $closeParen, $afterClose, $varContent );
+			$this->reportAndFix( $phpcsFile, $stackPtr, $afterClose );
@@
-	private function reportAndFix( File $phpcsFile, $isArrayStart, $isArrayEnd, $andToken, $varContent ) {
+	private function reportAndFix( File $phpcsFile, $isArrayStart, $andToken ) {