Update sniff to catch more redundant parentheses

[Crabcyborg]

Summary by CodeRabbit

• New Features

  • Enhanced code analysis to detect redundant parentheses in logical expressions with improved accuracy.

• Chores

  • Reorganized code style rule categorization for better structure.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

Added new detection logic to identify redundant parentheses around simple comparisons within logical expressions in RedundantParenthesesSniff. Extended the existing simple comparison detector to reject expressions containing arithmetic operators. Relocated a rule from CodeAnalysis to Commenting category in the ruleset configuration.

Changes

Cohort / File(s)	Summary
Redundant Parentheses Detection Logic phpcs-sniffs/Formidable/Sniffs/CodeAnalysis/RedundantParenthesesSniff.php	Added private method isRedundantComparisonInLogicalExpression to validate token context (logical operators, parentheses) around comparisons. Extended isSimpleComparisonExpression with arithmetic operator counting; now rejects expressions with arithmetic tokens. Introduced token groups for comparisons and arithmetic operators.
Ruleset Organization phpcs-sniffs/Formidable/ruleset.xml	Moved rule Formidable.Commenting.AlignFilterParamTypesWithFunction from CodeAnalysis section to Commenting section.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• Improve redundant parantheses sniff #2793: Modifies RedundantParenthesesSniff internals to refine simple-expression detection logic for redundant parentheses.
• Improve redundant paren sniff and remove is_array checks before stric… #2845: Extends isSimpleComparisonExpression and related logic in RedundantParenthesesSniff for detecting redundant comparison parentheses.
• Remove more useless parentheses #2767: Modifies RedundantParenthesesSniff logic for detecting redundant parentheses in expressions.

Poem

🐰 Parentheses once nested deep,
Now unwrapped from logical sleep,
Arithmetic operators banned,
Comparisons cleaner, neatly planned!
Hopping through code, so refined,
Redundancy left far behind! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: enhancing a PHPCS sniff to detect additional cases of redundant parentheses, particularly in logical expressions.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}