Add sync for stalkers #2255
Open
Add sync for stalkers #2255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coding-Hen
reviewed
Jan 12, 2025
dartasen
force-pushed
the
feature/stalkersync
branch
from
24c8a58 to
19d2afe
Compare
dartasen
force-pushed
the
feature/stalkersync
branch
from
7029e10 to
f916df4
Compare
dartasen
force-pushed
the
feature/stalkersync
branch
from
f916df4 to
b47a533
Compare
This comment has been minimized.
This comment has been minimized.
dartasen
force-pushed
the
feature/stalkersync
branch
2 times, most recently
from
f98dea9 to
8844ac0
Compare
There was a problem hiding this comment.
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
NitroxClient/GameLogic/Spawning/Metadata/Extractor/StayAtLeashPositionMetadataExtractor.cs:7
- The class name 'StayAtLeastPositionMetadataExtractor' appears inconsistent with the metadata type 'StayAtLeashPositionMetadata'; renaming it to 'StayAtLeashPositionMetadataExtractor' would improve clarity.
public sealed class StayAtLeastPositionMetadataExtractor : EntityMetadataExtractor<Creature, StayAtLeashPositionMetadata>
8844ac0 to
50240e7
Compare
Coding-Hen
requested changes
Apr 12, 2025
NitroxPatcher/Patches/Dynamic/PrisonPredatorSwimToPlayer_Perform_Patch.cs
Outdated
Show resolved
Hide resolved
NitroxPatcher/Patches/Dynamic/PrisonPredatorSwimToPlayer_Perform_Patch.cs
Show resolved
Hide resolved
dartasen
force-pushed
the
feature/stalkersync
branch
2 times, most recently
from
ae17e14 to
0d25ae2
Compare
dartasen
force-pushed
the
feature/stalkersync
branch
from
0d25ae2 to
063426c
Compare
Jannify
requested changes
May 3, 2025
NitroxPatcher/Patches/Dynamic/PrisonPredatorSwimToPlayer_Perform_Patch.cs
Show resolved
Hide resolved
Comment on lines
+21
to
+28
| public static IEnumerable<CodeInstruction> Transpiler(IEnumerable<CodeInstruction> instructions) | ||
| { | ||
| yield return new CodeInstruction(OpCodes.Ldarg_0); | ||
| yield return new CodeInstruction(OpCodes.Ldarg_1); | ||
| yield return new CodeInstruction(OpCodes.Ldarg_2); | ||
| yield return new CodeInstruction(OpCodes.Call, Reflect.Method(() => Perform(default, default, default))); | ||
| yield return new CodeInstruction(OpCodes.Ret); | ||
| } |
Member
There was a problem hiding this comment.
I would argue that it's fairly doable to do a little transpiler magic to just replace the local transform(stloc.1) and targetDirection(stloc..2) variables with the once from the lastTarget, no?
| instance.swimBehaviour.SwimTo(targetTransform.position, instance.swimVelocity); | ||
| creature.TryGetNitroxId(out NitroxId nitroxId); | ||
|
|
||
| Log.InGame($"[PrisonPredatorSwimTo Swim] {creature.name} {nitroxId?.ToString()} {lastTarget.target.name}"); |
NitroxPatcher/Patches/Dynamic/PrisonPredatorSwimToPlayer_Evaluate_Patch.cs
Outdated
Show resolved
Hide resolved
NitroxPatcher/Patches/Dynamic/PrisonPredatorSwimToPlayer_Evaluate_Patch.cs
Outdated
Show resolved
Hide resolved
NitroxPatcher/Patches/Dynamic/PrisonPredatorSwimToPlayer_Evaluate_Patch.cs
Outdated
Show resolved
Hide resolved
Comment on lines
+76
to
+78
| creature.TryGetNitroxId(out NitroxId nitroxId); | ||
|
|
||
| Log.InGame($"[PrisonPredatorSwimTo Eval] {creature.name} {nitroxId?.ToString()} {gameobject.name}"); |
Comment on lines
+27
to
+31
| yield return new CodeInstruction(OpCodes.Ldarg_0); | ||
| yield return new CodeInstruction(OpCodes.Ldarg_1); | ||
| yield return new CodeInstruction(OpCodes.Ldarg_2); | ||
| yield return new CodeInstruction(OpCodes.Call, Reflect.Method(() => EvaluatePriority(default, default, default))); | ||
| yield return new CodeInstruction(OpCodes.Ret); |
Member
There was a problem hiding this comment.
Like in PrisonPredatorSwimToPlayer_Perform_Patch I think we can manipulated the IL to get the same outcome.
Creating a new local variable, filling it with the ecoTarget and then replacing all usings of the Player local variable with the new one should work.
Collaborator
|
This comment was marked as spam.
This comment was marked as spam.
dartasen
force-pushed
the
feature/stalkersync
branch
from
063426c to
025ee09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CreatureFlinchCreatureFearPrisonCreatureBehaviourAvoidObstaclesStayAtLeashPositionWill need work after this PR :
Closes #2250
Closes #2243