initial exclude optimizer implementation#69
Conversation
commit: |
|
I would also suggest to add a test that does some performance check and compare results with globby |
538393a to
d06c985
Compare
d06c985 to
8c684ec
Compare
|
for anyone interested in helping, this PR makes vite tests fail, but we are struggling to debug it due to the message produced (and a lack of time). you can see the ci run on my test fork https://github.com/SuperchupuDev/vite |
|
After some debugging, seems like the problematic one was lone double star |
|
@SuperchupuDev could you merge @xuanduc987 changes and retry vite tests? |
|
cc @xiboon |
merged, thanks :) |
|
vite tests pass :O |
|
testing in some more repos, 3 tests from |
|
@SuperchupuDev Isn't the reason for the failing tests is this? |
|
oh, right, thought i had reverted that... my bad ci green again, thanks |
This reverts commit 8c684ec.
SuperchupuDev
left a comment
There was a problem hiding this comment.
there are some improvements that can be done (and i'll try to do before a new release), but it's good as an initial implementation. thanks everyone for the help! :)
Closes #46 yay....!!!!