Conversation
Contributor
|
@goksel can you review this one? |
Contributor
|
Jake, apologies, I should have done this already. The changes look ok. However,tThe SBOL Visual Ontology is autogenerated. Do we want to start manually updating the ontology or shall I update the ontology via the script which uses after the Glyph directory files when generating the ontology? |
Contributor
Author
|
@goksel I'd like to go with a third option: can you please add documentation and any missing code to the repository so that others (including me) can run the autogeneration? Expanding the update workflow to include the ontology is one of the big goals that I'd like to see accomplished between now and the end of COMBINE. |
Contributor
Author
|
Closing in favor of #106 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per issue #96, I have created a draft adjustment of the ontology that organizes all glyphs into the four subclasses provided by the ontology.
This still needs verification and also regeneration of HTML. @goksel , can you please instruct on how to do that? I do not find anything in the README at present.