Skip to content

Added the four main Glyph categories and updated the README file#106

Closed
goksel wants to merge 1 commit intomasterfrom
issue96
Closed

Added the four main Glyph categories and updated the README file#106
goksel wants to merge 1 commit intomasterfrom
issue96

Conversation

@goksel
Copy link
Contributor

@goksel goksel commented Oct 2, 2020

No description provided.

@goksel goksel requested a review from jakebeal October 2, 2020 10:33
<owl:someValuesFrom>
<owl:Restriction>
<owl:onProperty rdf:resource="http://sbols.org/v2#type"/>
<owl:someValuesFrom rdf:resource="http://identifiers.org/sbo/SBO:0000169"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems to have removed all of the SBO restrictions for interactions; we don't want to lose that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same is the case for all of the other interactions

Copy link
Contributor

@jakebeal jakebeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SBO restrictions appear to have been lost for interactions.

@jakebeal
Copy link
Contributor

jakebeal commented Oct 2, 2020

Note: addressing #96

@goksel
Copy link
Contributor Author

goksel commented Nov 29, 2020

@jakebeal Please check merge the pull request #133.

@jakebeal
Copy link
Contributor

I've added a comment on #133, and am waiting for your response there.

Can this one be closed as obsolete?

@jakebeal
Copy link
Contributor

jakebeal commented Dec 1, 2020

Superseded by #133. @goksel , can you delete the branch if it is no longer needed?

@jakebeal jakebeal closed this Dec 1, 2020
@goksel goksel deleted the issue96 branch December 1, 2020 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments