Skip to content

closes #430#431

Merged
jakebeal merged 1 commit intoSynBioDex:masterfrom
manulera:issue_430
Apr 11, 2024
Merged

closes #430#431
jakebeal merged 1 commit intoSynBioDex:masterfrom
manulera:issue_430

Conversation

@manulera
Copy link
Member

closes #430

Copy link
Collaborator

@jakebeal jakebeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am startled that this persisted as an issue here for so long, but so far as I can tell it is in fact an error. I can reproduce #430, and this addresses the issue without breaking anything else.

@jakebeal jakebeal merged commit c897809 into SynBioDex:master Apr 11, 2024
@jakebeal
Copy link
Collaborator

In retrospect, I should not have approved this without doing a push to force the action to run, because even though the tests passed locally for me they did break and identify an issue on GitHub

@manulera manulera mentioned this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug in ReferencedObject::__init__

2 participants

Comments