Skip to content

closes #430 #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakebeal merged 1 commit into from
Apr 11, 2024
Merged

closes #430 #431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sbol2/property.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -935,7 +935,7 @@ def __init__(self, property_owner, type_uri, reference_type_uri,
super().__init__(property_owner, type_uri, lower_bound, upper_bound,
validation_rules, initial_value)
self.reference_type_uri = reference_type_uri
if self._sbol_owner is not None:
if self._sbol_owner is None:
property_store = []
self._sbol_owner.properties[type_uri] = property_store

Expand Down
5 changes: 5 additions & 0 deletions test/test_participation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@ def test_add_remove_role(self):
p.removeRole(1)
self.assertEqual([sbol2.SO_PROMOTER, sbol2.SO_CDS], p.roles)

def test_init_with_participant(self):

p = sbol2.Participation('p', participant='p1')
self.assertEqual('p1', p.participant)


if __name__ == '__main__':
unittest.main()