-
Notifications
You must be signed in to change notification settings - Fork 0
task/WG-583: add check for data being public #262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task/WG-583: add check for data being public #262
Conversation
This reverts commit 275ac4d.
|
I haven't reviewed the changes live yet, but my initial thought on the UI (which looks great!!) is that "View in DesignSafe"" would make more sense than "Open in Designsafe". Technically you are not opening the file when you follow thath link, just viewing its location so you can download it. Opening implies that you would actually be viewing the file contents, so a file listing may be confusing to some users. I know, very pedantic, just being thorough... ;) |
👍 switching to "View in DesignSafe" |
Make the unique constraint rename conditional to support: - Old deployments (i.e. have PostgreSQL's default name at that time: auth_user_id_key) - Fresh DBs and deployments that already ran it (have SQLAlchemy naming_convention name: uq_auth_user_id) Without this fix, a fresh DB would fail on this migration: constraint "auth_user_id_key" of relation "auth" does not exist
sophia-massie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Paths direct to the correct place
✅ Published/Community data assets pass the public published check
✅ Unpublished assets show as private as expected
✅ Make public shows public/private status correctly and publlish the map
LGTM! Great work!
Overview:
Related Jira tickets:
Testing Steps:
Note: Test with TACC-Cloud/hazmapper#385
Note: If creating a DS project to publish, remember to only do that on https://pprd.designsafe-ci.org/
docker exec -it geoapi_backend alembic upgrade headThen more extensive testing can be done
Testing: creating a new map with data and then publishing data
Testing: look at existing maps
-Check if file accessibility check works as expected.
-Confirm that it fixes paths for previously imported images or point clouds
Testing: Importing from Published Projects or Community Data
for Community data we found these files:
Screenshots
Notes
Follow-on work:
TODO