Skip to content

Conversation

@nathanfranklin
Copy link
Collaborator

@nathanfranklin nathanfranklin commented Nov 6, 2025

Overview:

  • Keep track of original_system for imported files (WG-384)
  • Support checking for source files being public (WG-583)
  • Provide "View in DesignSafe" button on selected asset panel (replaces "Download") (WG-116)

Related Jira tickets:

Testing Steps:

Note: Test with TACC-Cloud/hazmapper#385
Note: If creating a DS project to publish, remember to only do that on https://pprd.designsafe-ci.org/

  1. Ensure you have run new migrations: docker exec -it geoapi_backend alembic upgrade head
  2. Run checks under "File Accessibility" in the Manage Panel
  3. See the same/similar checks done for the user in the "Make Public" in the Manage Panel
  4. Confirm all links on those modals work as expected

Then more extensive testing can be done

Testing: creating a new map with data and then publishing data

  1. Create a new DS project on https://pprd.designsafe-ci.org/
  2. Copy data from PRJ-4185 | GEOAPI -- Test project data (DO NOT EDIT) to the this new project
  3. Create a new map attached to that DS project
  4. Import files from your DS project into your map
  5. Check accessibility
  6. Publish some of those files
  7. Check accessibility again

Testing: look at existing maps

-Check if file accessibility check works as expected.
-Confirm that it fixes paths for previously imported images or point clouds

Testing: Importing from Published Projects or Community Data

  • Check that files imported directly from existing Published Projects behave as expected in the file accessibility ui
  • Check that files imported directly from existing Community Databehave as expected in the file accessibility ui

for Community data we found these files:

  • /Machine_Learning_Bootcamp/CNN_Image_Classification/Dataset_1/Train/C4/0056732e-9b52-4b7e-ac67-e41a05f37116.jpg
  • /GIS_workshop/GIS/DATA/Galveston_Hurricane/DEM_Galv_Tif/dem_10m_prj.tif ( to be imported as Geotiff in Layers menu)

Screenshots

Screenshot 2025-11-19 at 4 23 12 PM Screenshot 2025-11-24 at 4 50 57 PM

Notes

Follow-on work:

  • Added WG-600 to improve things so we can track shapfiles/geojson.
  • Added WG-607 to use legacyPath

TODO

  • point cloud creation should save original system and path
  • db mixin should apply this info to tile layer model as well

@nathanfranklin nathanfranklin changed the title Task/583 add check for data being public task/583: add check for data being public Nov 7, 2025
@nathanfranklin nathanfranklin changed the title task/583: add check for data being public task/WG-583: add check for data being public Nov 7, 2025
@taoteg
Copy link
Contributor

taoteg commented Nov 24, 2025

I haven't reviewed the changes live yet, but my initial thought on the UI (which looks great!!) is that "View in DesignSafe"" would make more sense than "Open in Designsafe". Technically you are not opening the file when you follow thath link, just viewing its location so you can download it. Opening implies that you would actually be viewing the file contents, so a file listing may be confusing to some users. I know, very pedantic, just being thorough... ;)

@nathanfranklin
Copy link
Collaborator Author

I haven't reviewed the changes live yet, but my initial thought on the UI (which looks great!!) is that "View in DesignSafe"" would make more sense than "Open in Designsafe". Technically you are not opening the file when you follow thath link, just viewing its location so you can download it. Opening implies that you would actually be viewing the file contents, so a file listing may be confusing to some users. I know, very pedantic, just being thorough... ;)

👍 switching to "View in DesignSafe"

nathanfranklin and others added 4 commits November 25, 2025 14:58
Make the unique constraint rename conditional to support:
- Old deployments (i.e. have PostgreSQL's
  default name at that time: auth_user_id_key)
- Fresh DBs and deployments that already ran it (have SQLAlchemy
  naming_convention name: uq_auth_user_id)

Without this fix, a fresh DB would fail on this migration:
  constraint "auth_user_id_key" of relation "auth" does not exist
Copy link
Contributor

@sophia-massie sophia-massie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Paths direct to the correct place
✅ Published/Community data assets pass the public published check
✅ Unpublished assets show as private as expected
✅ Make public shows public/private status correctly and publlish the map

LGTM! Great work!

@nathanfranklin nathanfranklin merged commit ac9f073 into main Dec 9, 2025
3 checks passed
@nathanfranklin nathanfranklin deleted the task/583-add-check-for-data-being-public branch December 9, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants