feat: feature flags + projects message - in-page #519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleyboar
requested review from
jarosenb and
sophia-massie
and removed request for
jarosenb
* feat: feature-flag–based error message (!) (!) style and layout incomplete, just testing * fix: change error message, link to news * Adds styles and addresses right margin issue * Linting --------- Co-authored-by: Sophia Massie-Perez <smassie@smassie-mbp25.local>
wesleyboar
changed the title
This was referenced Oct 31, 2025
Merged
sophia-massie
approved these changes
Oct 31, 2025
| export default defineConfig({ | ||
| root: __dirname, | ||
| cacheDir: '../../node_modules/.vite/tup-ui', | ||
| // envPrefix: 'VITE_', |
Collaborator
There was a problem hiding this comment.
Do you want to leave this comment in here?
Member
Author
There was a problem hiding this comment.
Yes/No. I want us noobs to know that VITE_ (default value) has a special meaning. Without that prefix, the value is not available to client app. And I'd like to suggest we can change it. I could enable it and comment the doc URL —
Suggested change
| // envPrefix: 'VITE_', | |
| envPrefix: 'VITE_', // https://vite.dev/config/shared-options.html#envprefix |
— thoughts?
Collaborator
There was a problem hiding this comment.
OK perfect I like this
Member
Author
|
Closed in favor of #522. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add feature flag and warn about maintenance.
Important
Credit to Sophia for helping style message.
Related
Changes
.envfor flagsTesting
UI
page.messages.mov