fix(types): support both Array and ReadonlyArray for typed query and mutation keys#8529
Merged
TkDodo merged 2 commits intoTanStack:mainfrom Jan 13, 2025
Merged
Conversation
…and mutation keys
|
View your CI Pipeline Execution ↗ for commit 35beb72.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8529 +/- ##
===========================================
+ Coverage 46.28% 63.04% +16.76%
===========================================
Files 199 135 -64
Lines 7538 4820 -2718
Branches 1722 1347 -375
===========================================
- Hits 3489 3039 -450
+ Misses 3670 1549 -2121
+ Partials 379 232 -147 |
TkDodo
approved these changes
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #8521
When using this new feature I've realised that it currently doesn't support
ReadonlyArrays, as they don't extend theArraytype, which I didn't appreciate until now. Some users may want to provide aReadonlyArraytoRegisterfor extra type safety. This PR updates the inference so that it will support both.