Skip to content

fix(types): support both Array and ReadonlyArray for typed query and mutation keys #8529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TkDodo merged 2 commits into from
Jan 13, 2025
Merged

fix(types): support both Array and ReadonlyArray for typed query and mutation keys #8529

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
455f081
fix(types): support both `Array` and `ReadonlyArray` for typed query …
neefrehman Jan 13, 2025
35beb72
ci: apply automated fixes
autofix-ci[bot] Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions packages/query-core/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,11 @@ export type DefaultError = Register extends {
export type QueryKey = Register extends {
queryKey: infer TQueryKey
}
? TQueryKey extends Array<unknown>
? TQueryKey extends ReadonlyArray<unknown>
? TQueryKey
: ReadonlyArray<unknown>
: TQueryKey extends Array<unknown>
? TQueryKey
: ReadonlyArray<unknown>
: ReadonlyArray<unknown>

export const dataTagSymbol = Symbol('dataTagSymbol')
Expand Down Expand Up @@ -1009,7 +1011,9 @@ export type MutationKey = Register extends {
}
? TMutationKey extends Array<unknown>
? TMutationKey
: ReadonlyArray<unknown>
: TMutationKey extends Array<unknown>
? TMutationKey
: ReadonlyArray<unknown>
: ReadonlyArray<unknown>

export type MutationStatus = 'idle' | 'pending' | 'success' | 'error'
Expand Down