feat: allow use of nitro zero conf#3993
Conversation
|
View your CI Pipeline Execution ↗ for commit 6b7c912.
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/arktype-adapter
@tanstack/directive-functions-plugin
@tanstack/history
@tanstack/eslint-plugin-router
@tanstack/react-router
@tanstack/react-router-devtools
@tanstack/react-router-with-query
@tanstack/react-start
@tanstack/react-start-client
@tanstack/react-start-config
@tanstack/react-start-plugin
@tanstack/react-start-router-manifest
@tanstack/react-start-server
@tanstack/router-cli
@tanstack/router-core
@tanstack/router-devtools
@tanstack/router-devtools-core
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/solid-router
@tanstack/solid-router-devtools
@tanstack/solid-start
@tanstack/solid-start-client
@tanstack/solid-start-config
@tanstack/solid-start-plugin
@tanstack/solid-start-router-manifest
@tanstack/solid-start-server
@tanstack/start
@tanstack/start-api-routes
@tanstack/start-client-core
@tanstack/start-config
@tanstack/start-server-core
@tanstack/start-server-functions-client
@tanstack/start-server-functions-fetcher
@tanstack/start-server-functions-handler
@tanstack/start-server-functions-server
@tanstack/start-server-functions-ssr
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/zod-adapter
commit: |
zrosenbauer
left a comment
There was a problem hiding this comment.
Since this is native, LGTM... just make sure the tests pass and then I can approve.
|
@zrosenbauer I couldn't see actual test failing in last run. Those tests also did pass locally for me.
Cloud test runner seemed to crash because of
As I'm not that familiar with CI here, I'm not sure if this is potentially recurring problem happening from time to time due to overall test setup or if it's actually caused by this change ( but this would be pretty unexpected to me, unless somehow Nitro's platform detection is very memory hungry) |
Yea most likely just get those approved and were good |
serhalp
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing!
c1ce053 to
6b7c912
Compare
This reverts commit 8edeeaa.
Ref: https://nitro.build/deploy#zero-config-providers
Nitro will automatically fallback to
node-serverif it doesn't recognize environment of one of supported zero configuration deploy targets https://nitro.build/deploy#default-output.Note nksaraf/vinxi#325 was similar change done some time ago in Vinxi to allow for zero-configuration