Skip to content

feat: allow use of nitro zero conf #3993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schiller-manuel merged 2 commits into from
Apr 25, 2025
Merged

feat: allow use of nitro zero conf #3993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afa3e6f
feat: allow use of nitro zero conf
pieh Apr 14, 2025
6b7c912
ci: apply automated fixes
autofix-ci[bot] Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/react-start-config/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,7 @@ export async function defineConfig(
const { preset: configDeploymentPreset, ...serverOptions } =
serverSchema.parse(opts.server || {})

const deploymentPreset = checkDeploymentPresetInput(
configDeploymentPreset || 'node-server',
)
const deploymentPreset = checkDeploymentPresetInput(configDeploymentPreset)
const tsr = setTsrDefaults(opts.tsr)
const tsrConfig = getConfig(tsr)

Expand Down
30 changes: 17 additions & 13 deletions packages/react-start-config/src/schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,19 +80,23 @@ const testedDeploymentPresets: Array<DeploymentPreset> = [
'node-server',
]

export function checkDeploymentPresetInput(preset: string): DeploymentPreset {
if (!vinxiDeploymentPresets.includes(preset as any)) {
console.warn(
`Invalid deployment preset "${preset}". Available presets are: ${vinxiDeploymentPresets
.map((p) => `"${p}"`)
.join(', ')}.`,
)
}

if (!testedDeploymentPresets.includes(preset as any)) {
console.warn(
`The deployment preset '${preset}' is not fully supported yet and may not work as expected.`,
)
export function checkDeploymentPresetInput(
preset?: string,
): DeploymentPreset | undefined {
if (preset) {
if (!vinxiDeploymentPresets.includes(preset as any)) {
console.warn(
`Invalid deployment preset "${preset}". Available presets are: ${vinxiDeploymentPresets
.map((p) => `"${p}"`)
.join(', ')}.`,
)
}

if (!testedDeploymentPresets.includes(preset as any)) {
console.warn(
`The deployment preset '${preset}' is not fully supported yet and may not work as expected.`,
)
}
}

return preset
Expand Down
4 changes: 1 addition & 3 deletions packages/solid-start-config/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,7 @@ export async function defineConfig(
const { preset: configDeploymentPreset, ...serverOptions } =
serverSchema.parse(opts.server || {})

const deploymentPreset = checkDeploymentPresetInput(
configDeploymentPreset || 'node-server',
)
const deploymentPreset = checkDeploymentPresetInput(configDeploymentPreset)
const tsr = setTsrDefaults(opts.tsr)
const tsrConfig = getConfig(tsr)

Expand Down
30 changes: 17 additions & 13 deletions packages/solid-start-config/src/schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,19 +80,23 @@ const testedDeploymentPresets: Array<DeploymentPreset> = [
'node-server',
]

export function checkDeploymentPresetInput(preset: string): DeploymentPreset {
if (!vinxiDeploymentPresets.includes(preset as any)) {
console.warn(
`Invalid deployment preset "${preset}". Available presets are: ${vinxiDeploymentPresets
.map((p) => `"${p}"`)
.join(', ')}.`,
)
}

if (!testedDeploymentPresets.includes(preset as any)) {
console.warn(
`The deployment preset '${preset}' is not fully supported yet and may not work as expected.`,
)
export function checkDeploymentPresetInput(
preset?: string,
): DeploymentPreset | undefined {
if (preset) {
if (!vinxiDeploymentPresets.includes(preset as any)) {
console.warn(
`Invalid deployment preset "${preset}". Available presets are: ${vinxiDeploymentPresets
.map((p) => `"${p}"`)
.join(', ')}.`,
)
}

if (!testedDeploymentPresets.includes(preset as any)) {
console.warn(
`The deployment preset '${preset}' is not fully supported yet and may not work as expected.`,
)
}
}

return preset
Expand Down
4 changes: 1 addition & 3 deletions packages/start-config/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,7 @@ export async function defineConfig(
const { preset: configDeploymentPreset, ...serverOptions } =
serverSchema.parse(opts.server || {})

const deploymentPreset = checkDeploymentPresetInput(
configDeploymentPreset || 'node-server',
)
const deploymentPreset = checkDeploymentPresetInput(configDeploymentPreset)
const tsr = setTsrDefaults(opts.tsr)
const tsrConfig = getConfig(tsr)

Expand Down
30 changes: 17 additions & 13 deletions packages/start-config/src/schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,19 +80,23 @@ const testedDeploymentPresets: Array<DeploymentPreset> = [
'node-server',
]

export function checkDeploymentPresetInput(preset: string): DeploymentPreset {
if (!vinxiDeploymentPresets.includes(preset as any)) {
console.warn(
`Invalid deployment preset "${preset}". Available presets are: ${vinxiDeploymentPresets
.map((p) => `"${p}"`)
.join(', ')}.`,
)
}

if (!testedDeploymentPresets.includes(preset as any)) {
console.warn(
`The deployment preset '${preset}' is not fully supported yet and may not work as expected.`,
)
export function checkDeploymentPresetInput(
preset?: string,
): DeploymentPreset | undefined {
if (preset) {
if (!vinxiDeploymentPresets.includes(preset as any)) {
console.warn(
`Invalid deployment preset "${preset}". Available presets are: ${vinxiDeploymentPresets
.map((p) => `"${p}"`)
.join(', ')}.`,
)
}

if (!testedDeploymentPresets.includes(preset as any)) {
console.warn(
`The deployment preset '${preset}' is not fully supported yet and may not work as expected.`,
)
}
}

return preset
Expand Down
Loading