feat: 프로필 비공개 여부 버튼 > 토글 버튼으로 수정 #639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m6z1
commented
Apr 19, 2025
| quitNovelCount = quitNovelCount, | ||
| ) | ||
|
|
||
| fun UserProfileStatusResponseDto.toData(): UserProfileStatusEntity = |
Member
Author
There was a problem hiding this comment.
Boolean 값 하나만 DTO 로 오는데 Entity 까지는 불필요하다고 판단했습니다.
또한, 다른 코드와 얼라인을 맞추기 위해 Entity 삭제와 Mapper 함수 삭제했습니다.
yeonjeen
approved these changes
Apr 19, 2025
| app:layout_constraintEnd_toEndOf="parent" | ||
| app:layout_constraintTop_toTopOf="parent" /> | ||
| app:layout_constraintTop_toTopOf="parent" | ||
| app:track="@drawable/bg_notification_setting_toggle" /> |
Member
There was a problem hiding this comment.
a: 제가 해당 속성을 처음봐서 그런데 어떤 속성인가요??
Member
Author
There was a problem hiding this comment.
토글 버튼의 트랙(배경 이미지 ?)를 설정하는 친구입니다
이 이미지에서 동그란 흰색은 thumb / 회색 배경의 타원은 track
s9hn
approved these changes
Apr 21, 2025
| ) | ||
| setResult(ChangeProfileDisclosure.RESULT_OK, intent) | ||
| finish() | ||
| return@setOnClickListener |
Member
Author
There was a problem hiding this comment.
습관성 얼리 리턴이었는데 ㅎㅎ ,,
finish 를 통해 해당 액티비티가 소멸하기에 해당 리턴 불필요하다고 판단해 제거했습니다.
d9db0b8
Member
There was a problem hiding this comment.
어떤 분기든 결국 finish()로 귀결되니 맨 마지막 finish만 남겨둬도 괜찮을 것 같아요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌𝘐𝘴𝘴𝘶𝘦𝘴
📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯
isChangedStatus로 상태 초기값과 저장된 값이 다른지 파악해 뒤로가기 버튼을 눌렀을 때 스낵바가 뜰 수 있도록 했습니다.📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵
2025-04-20.2.08.45.mov
💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴