-
Notifications
You must be signed in to change notification settings - Fork 0
feat: 프로필 비공개 여부 버튼 > 토글 버튼으로 수정 #639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,16 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <layout xmlns:android="http://schemas.android.com/apk/res/android" | ||
| xmlns:app="http://schemas.android.com/apk/res-auto" | ||
| xmlns:tools="http://schemas.android.com/tools"> | ||
| xmlns:app="http://schemas.android.com/apk/res-auto"> | ||
|
|
||
| <data> | ||
|
|
||
| <variable | ||
| name="profileDisclosureViewModel" | ||
| type="com.into.websoso.ui.profileDisclosure.ProfileDisclosureViewModel" /> | ||
|
|
||
| <variable | ||
| name="onToggleClick" | ||
| type="kotlin.jvm.functions.Function0" /> | ||
| </data> | ||
|
|
||
| <androidx.constraintlayout.widget.ConstraintLayout | ||
|
|
@@ -40,24 +43,11 @@ | |
| app:layout_constraintStart_toStartOf="parent" | ||
| app:layout_constraintTop_toTopOf="parent" /> | ||
|
|
||
| <TextView | ||
| android:id="@+id/tv_profile_disclosure_complete_button" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:layout_marginEnd="12dp" | ||
| android:enabled="@{profileDisclosureViewModel.isCompleteButtonEnabled}" | ||
| android:padding="10dp" | ||
| android:text="@string/profile_disclosure_complete" | ||
| android:textAppearance="@style/title2" | ||
| android:textColor="@color/bg_profile_disclosure_text_selector" | ||
| app:layout_constraintBottom_toBottomOf="@id/tv_profile_disclosure_title" | ||
| app:layout_constraintEnd_toEndOf="parent" | ||
| app:layout_constraintTop_toTopOf="@id/tv_profile_disclosure_title" /> | ||
|
|
||
| <androidx.constraintlayout.widget.ConstraintLayout | ||
| android:id="@+id/cl_profile_disclosure_button" | ||
| android:layout_width="0dp" | ||
| android:layout_height="wrap_content" | ||
| android:onClick="@{() -> onToggleClick.invoke()}" | ||
| android:paddingHorizontal="20dp" | ||
| android:paddingVertical="10dp" | ||
| app:layout_constraintEnd_toEndOf="parent" | ||
|
|
@@ -67,32 +57,26 @@ | |
| <TextView | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:paddingVertical="10dp" | ||
| android:text="@string/profile_disclosure_private" | ||
| android:textAppearance="@style/body1" | ||
| android:textColor="@color/black" | ||
| app:layout_constraintBottom_toBottomOf="parent" | ||
| app:layout_constraintStart_toStartOf="parent" | ||
| app:layout_constraintTop_toTopOf="parent" /> | ||
|
|
||
| <ImageView | ||
| android:id="@+id/iv_profile_disclosure_status_button" | ||
| <androidx.appcompat.widget.SwitchCompat | ||
| android:id="@+id/sc_profile_disclosure_toggle" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:padding="10dp" | ||
| android:src="@drawable/img_account_info_check_unselected" | ||
| android:layout_height="0dp" | ||
| android:background="@null" | ||
| android:checked="@{profileDisclosureViewModel.isProfilePrivate}" | ||
| android:clickable="false" | ||
| android:thumb="@drawable/bg_notification_setting_toggle_thumb" | ||
| app:layout_constraintBottom_toBottomOf="parent" | ||
| app:layout_constraintEnd_toEndOf="parent" | ||
| app:layout_constraintTop_toTopOf="parent" /> | ||
| app:layout_constraintTop_toTopOf="parent" | ||
| app:track="@drawable/bg_notification_setting_toggle" /> | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. a: 제가 해당 속성을 처음봐서 그런데 어떤 속성인가요??
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 오오 아직도 모르는게 많은 xml의 세계... |
||
| </androidx.constraintlayout.widget.ConstraintLayout> | ||
|
|
||
| <com.into.websoso.core.common.ui.custom.WebsosoLoadingLayout | ||
| android:id="@+id/wll_profile_disclosure" | ||
| android:layout_width="0dp" | ||
| android:layout_height="0dp" | ||
| app:layout_constraintBottom_toBottomOf="parent" | ||
| app:layout_constraintEnd_toEndOf="parent" | ||
| app:layout_constraintStart_toStartOf="parent" | ||
| app:layout_constraintTop_toTopOf="parent" | ||
| tools:visibility="gone" /> | ||
| </androidx.constraintlayout.widget.ConstraintLayout> | ||
| </layout> | ||

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Boolean 값 하나만 DTO 로 오는데 Entity 까지는 불필요하다고 판단했습니다.
또한, 다른 코드와 얼라인을 맞추기 위해 Entity 삭제와 Mapper 함수 삭제했습니다.