Skip to content

updated pr-data.csv#1001

Merged
darko-marinov merged 1 commit intoTestingResearchIllinois:mainfrom
kavvya97:kram_update_pr_data_csv
Nov 17, 2023
Merged

updated pr-data.csv#1001
darko-marinov merged 1 commit intoTestingResearchIllinois:mainfrom
kavvya97:kram_update_pr_data_csv

Conversation

@kavvya97
Copy link
Copy Markdown

Updated PR-data.csv
The following tests in cloudstack's module engine/schema are found to be id:
com.cloud.network.as.AutoScaleVmProfileVOTest#tstSetOtherDeployParamsForUpdate
com.cloud.network.as.AutoScaleVmProfileVOTest#testCounterParamsForUpdate

Opened a PR for the same
apache/cloudstack#8238

The detailed logs and issues is available in the PR

@zzjas
Copy link
Copy Markdown
Contributor

zzjas commented Nov 15, 2023

The format checker is failing because of sorting.

Also, the developer just replied. Please follow up. If your real PR is accepted before this PR is merged, simply update the status here.

@darko-marinov ok to merge once format checker passes

@kavvya97 kavvya97 force-pushed the kram_update_pr_data_csv branch from 16691ef to f49e62b Compare November 16, 2023 01:06
@darko-marinov darko-marinov merged commit 83437e1 into TestingResearchIllinois:main Nov 17, 2023
@darko-marinov
Copy link
Copy Markdown
Contributor

I'm accepting this for "points" but please do follow up on the real PR; it's way more important than this PR here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants