Refactor: use app_logo if app_logo_url is not present in installed apps#64
Merged
sumitjain236 merged 2 commits intomainfrom Sep 15, 2024
Conversation
…name is not valid fix: TypeError: string indices must be integers, not 'str'` when creating a new Commit Project #62
sumitjain236
deleted the
63-if-app_logo_url-is-not-available-try-using-app_logo-from-hookspy
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: before we only using app_logo_url as project logo from hooks.py for installed application of site, now if app_logo_url is not present then use app_logo
here in screenshot frappe logo is app_logo_url but raven is app_logo