Allow optional arguments for running tox#9
Conversation
Co-authored-by: Peter Kirchner <pkirch@users.noreply.github.com>
Use dependency injection to make function runTox testable. Co-authored-by: Oliver L <se02035@users.noreply.github.com>
Add dependency ts-mockito.
…re/add-tox-arguments
|
FYI, I'll mostly be away until after Easter (at PyConDE and then a digital arts event) - thus, I'll probably only get to reviewing this in 2 weeks or so. Meanwhile, thanks for the contribution and your patience! |
|
One down, six to go - thanks @pkirch! I pushed some small changes/improvements on top:
I felt like it was strange to always ask for arguments with I'm also not sure what's up with the big but I suppose after I regenerated it in ab9766a, that won't matter much anymore. In any case, thanks for taking care of adding a test as well, much appreciated! |
|
@The-Compiler Thanks for working through the PRs! I really appreciate your thoroughness in understanding the changes and aligning with your vision of the extension! |
Change the flow for running tox
python-tox.selectto accept optional arguments for tox, e.g. parameters like-vvor-- {posargs}.Changed function
runToxto use dependency injection to get thevscode.Terminalto be able to test this function.Add a unit test to verify the correct usage of the additional arguments using a mocked
vscode.Terminal.This PR sets the foundation for the enhancement mentioned in #2 and realizes #3.