Skip to content

Comments

Start Tox command from within the tox file (Test UI)#10

Merged
The-Compiler merged 14 commits intoThe-Compiler:mainfrom
The-V8:feature/start-envs-from-tox-ini
Jun 23, 2022
Merged

Start Tox command from within the tox file (Test UI)#10
The-Compiler merged 14 commits intoThe-Compiler:mainfrom
The-V8:feature/start-envs-from-tox-ini

Conversation

@starlord-daniel
Copy link
Contributor

@starlord-daniel starlord-daniel commented Apr 7, 2022

Additions

  • added samples with a simple tox file and Python tests
  • adapted gitignore
  • added vscode launch settings (to use sample files)
  • upgraded to vscode 1.59.0 (requirement for Test UI)
  • added logic for parsing tox to get commands to run through tests
  • added logic to call existing runTox for the chosen tests
  • reuse of terminal

How to test

  • meet the prerequisites described in the REAMDE.md
  • press F5 in VS Code to run the Run Extension launch command
  • in the test instance of VS Code, open the tox file
  • after loading, the tox commands can be executed (from file directly or the test explorer)
  • safe the tox file to trigger a re-parsing of the environments

Implements #11

@starlord-daniel starlord-daniel marked this pull request as draft April 7, 2022 12:38
Thanks for the comment, Peter!
@starlord-daniel starlord-daniel marked this pull request as ready for review April 7, 2022 14:07
@The-Compiler
Copy link
Owner

FYI, I'll mostly be away until after Easter (at PyConDE and then a digital arts event) - thus, I'll probably only get to reviewing this in 2 weeks or so. Meanwhile, thanks for the contribution and your patience!

@starlord-daniel
Copy link
Contributor Author

starlord-daniel commented Apr 8, 2022

FYI, I'll mostly be away until after Easter (at PyConDE and then a digital arts event) - thus, I'll probably only get to reviewing this in 2 weeks or so. Meanwhile, thanks for the contribution and your patience!

Thank you for the heads-up. I merged the changes from #9, so that we don't get conflicts, when it is merged first. Please contact me or @pkirch anytime, if you want to discuss the approaches a bit further than the discussion board.

@pkirch
Copy link
Contributor

pkirch commented Apr 25, 2022

@starlord-daniel, LGTM!

Only one remark: imho, it would look simpler and cleaner if the new functionality were in its own class.

@The-Compiler
Copy link
Owner

Thanks! Merged with a couple of cleanups I noticed when trying to understand the code (or more accurately, trying to understand the VS Code Testing API 😅):

  • 9826166 Cleanups in parseTestsInFileContents
  • cdc0043 Use TestItemCollection.replace in parseTestsInDocument
  • e92a7c1 Remove unneeded assignment
  • f1b8ace parseTestsInDocument: Use path.basename
  • 3875b2f Simplify open/save registration

I also opened a couple of follow-up issues I'd appreciate your input on:

The-Compiler added a commit that referenced this pull request Jun 23, 2022
Added in #10 but seem to break the build, see #23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants