fix: remove non-root overrides from MODULE.bazel#4157
fix: remove non-root overrides from MODULE.bazel#4157oharboe wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
Conversation
When ORFS is fetched as a non-root dependency, git_override and orfs.default() directives are ignored/illegal. Remove them so the module can be used as a dependency without errors. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
|
what replaces |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the git override and default configuration for the bazel-orfs dependency in MODULE.bazel. Feedback indicates that removing the git override requires adding a version to the bazel_dep declaration to ensure proper resolution. Additionally, the removal of use_repo calls for the orfs extension will likely cause build failures as those repositories will no longer be visible to the module.
| @@ -7,13 +7,6 @@ module( | |||
|
|
|||
| bazel_dep(name = "bazel-orfs") | |||
There was a problem hiding this comment.
The bazel_dep for bazel-orfs is missing a version. Since the git_override is being removed, a version must be specified so that Bazel can resolve the dependency via a registry. Without a version, this module will fail to load when used as a dependency by other projects.
| bazel_dep(name = "bazel-orfs") | |
| bazel_dep(name = "bazel-orfs", version = "0.0.1") |
| @@ -32,15 +25,3 @@ pip.parse( | |||
| use_repo(pip, "orfs-pip") | |||
|
|
|||
| orfs = use_extension("@bazel-orfs//:extension.bzl", "orfs_repositories") | |||
There was a problem hiding this comment.
The use_repo calls for com_github_nixos_patchelf_download and docker_orfs were removed, but they are likely still required. While the orfs.default() configuration tag might be restricted to the root module (depending on the extension's implementation), use_repo is the mechanism that makes the extension's repositories visible to this module. Removing these will cause build failures for any targets in this module that reference these repositories.
| orfs = use_extension("@bazel-orfs//:extension.bzl", "orfs_repositories") | |
| orfs = use_extension("@bazel-orfs//:extension.bzl", "orfs_repositories") | |
| use_repo(orfs, "com_github_nixos_patchelf_download") | |
| use_repo(orfs, "docker_orfs") |
|
ugh. Leave be for now. There's some boot strapping problem here I need to clean up with ORFS being a bazel project and also used to get to scripts+pdk. |
2 participants
When ORFS is fetched as a non-root dependency, git_override and orfs.default() directives are ignored/illegal. Remove them so the module can be used as a dependency without errors.