Skip to content

fix: remove non-root overrides from MODULE.bazel #4157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oharboe wants to merge 1 commit into from
+0 −19
Closed

fix: remove non-root overrides from MODULE.bazel #4157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,6 @@ module(

bazel_dep(name = "bazel-orfs")
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The bazel_dep for bazel-orfs is missing a version. Since the git_override is being removed, a version must be specified so that Bazel can resolve the dependency via a registry. Without a version, this module will fail to load when used as a dependency by other projects.

Suggested change
bazel_dep(name = "bazel-orfs")
bazel_dep(name = "bazel-orfs", version = "0.0.1")


# To bump version, run: bazelisk run @bazel-orfs//:bump
git_override(
module_name = "bazel-orfs",
commit = "f8a4b694b37c8f5322323eba9a9ae37f9541ee17",
remote = "https://github.com/The-OpenROAD-Project/bazel-orfs.git",
)

bazel_dep(name = "rules_python", version = "1.8.5")
bazel_dep(name = "rules_shell", version = "0.6.1")

Expand All @@ -32,15 +25,3 @@ pip.parse(
use_repo(pip, "orfs-pip")

orfs = use_extension("@bazel-orfs//:extension.bzl", "orfs_repositories")
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The use_repo calls for com_github_nixos_patchelf_download and docker_orfs were removed, but they are likely still required. While the orfs.default() configuration tag might be restricted to the root module (depending on the extension's implementation), use_repo is the mechanism that makes the extension's repositories visible to this module. Removing these will cause build failures for any targets in this module that reference these repositories.

Suggested change
orfs = use_extension("@bazel-orfs//:extension.bzl", "orfs_repositories")
orfs = use_extension("@bazel-orfs//:extension.bzl", "orfs_repositories")
use_repo(orfs, "com_github_nixos_patchelf_download")
use_repo(orfs, "docker_orfs")


# To bump version, run: bazelisk run @bazel-orfs//:bump
orfs.default(
image = "docker.io/openroad/orfs:v3.0-3273-gedf3d6bf",
# Use local files instead of docker image
makefile = "//flow:makefile",
makefile_yosys = "//flow:makefile_yosys",
pdk = "//flow:asap7",
sha256 = "f5692c6325ebcf27cc348e033355ec95c82c35ace1af7e72a0d352624ada143e",
)
use_repo(orfs, "com_github_nixos_patchelf_download")
use_repo(orfs, "docker_orfs")