Skip to content

Create command can now take single file; adding --name-in-archive parameter#116

Open
sjoblomj wants to merge 1 commit intoTheGrayDot:mainfrom
sjoblomj:improving-create-command
Open

Create command can now take single file; adding --name-in-archive parameter#116
sjoblomj wants to merge 1 commit intoTheGrayDot:mainfrom
sjoblomj:improving-create-command

Conversation

@sjoblomj
Copy link
Contributor

@sjoblomj sjoblomj commented Oct 21, 2025

This makes it easier to create an MPQ archive, if one only wants to add a single file

@sjoblomj sjoblomj force-pushed the improving-create-command branch from b271b87 to 1cc9fe5 Compare October 22, 2025 19:40
thomaslaurenson
thomaslaurenson requested changes Oct 31, 2025
View reviewed changes
Copy link
Collaborator

@thomaslaurenson thomaslaurenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another nice addition. Agree with the purpose and think it is a good addition. Only change would be to match the argument naming convention that we decide from #115, so replacing --name-in-archive with what is decided. Apart from that, great addition, and happy to merge after the argument change.

@sjoblomj
Copy link
Contributor Author

sjoblomj commented Nov 1, 2025 •
edited
Loading

Another nice addition. Agree with the purpose and think it is a good addition. Only change would be to match the argument naming convention that we decide from #115, so replacing --name-in-archive with what is decided. Apart from that, great addition, and happy to merge after the argument change.

Thank you. Let's keep the naming discussion in #115, and I'll update this PR, if that is what we conclude.

I think merging all my open PRs would lead to minor merge conflicts as it stands right now. To keep things simple, let's first merge #117 and the locale PRs, once you have checked them and agree with them. Afterwards, I can rebase and update this PR and #115.
Edit: Locale PRs are merged and this PR is updated to fix merge conflicts.

@sjoblomj sjoblomj mentioned this pull request Nov 1, 2025
Open
@sjoblomj sjoblomj mentioned this pull request Nov 24, 2025
Merged
@sjoblomj sjoblomj force-pushed the improving-create-command branch from 31ecc23 to 99c1b02 Compare November 27, 2025 17:17
@sjoblomj sjoblomj force-pushed the improving-create-command branch from 99c1b02 to 21bfd64 Compare November 27, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomaslaurenson thomaslaurenson thomaslaurenson requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sjoblomj @thomaslaurenson

Comments