Locale support - extract#121
Merged
thomaslaurenson merged 1 commit intoTheGrayDot:mainfrom Nov 25, 2025
Merged
Conversation
This was referenced Oct 26, 2025
Merged
Merged
584b11e to
3fc706e
Compare
Collaborator
|
Think I need a little guidance on how to proceed with these PRs. Guess you can see the history, but a brief summary:
|
7b2796f to
1587e13
Compare
Contributor
Author
I cherry-picked and force-pushed, so both this PR and #122 should be good to merge now. I'll sort out #115 and #116 later - in the meantime, we still have some open questions to decide on for those :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Locales are not supported in mpqcli, see #113. This PR adds locale support to the
extractsubcommand.This PR builds on top of #119, which in turns builds on top of #118, which in turn builds on top of #117.
Related PRs:
readsubcommandremovesubcommand