PR template: remove mention of solutions branch#113
Merged
Conversation
rlmoser99
reviewed
Dec 12, 2024
| - [ ] The `Because` section summarizes the reason for this PR | ||
| - [ ] The `This PR` section has a bullet point list describing the changes in this PR | ||
| - [ ] If this PR addresses an open issue, it is linked in the `Issue` section | ||
| - [ ] If this PR includes changes that needs to be updated on the `solutions` branch, I have created another PR (and linked it to this PR). |
Member
There was a problem hiding this comment.
I wonder if we should change this to something like this, because the purpose of this is to remind people that they may have to make changes in two places.
[ ] If this PR includes changes to exercises, they are also changed in the `solutions` folder.
Contributor
Author
There was a problem hiding this comment.
Oh this makes perfect sense. I'll make the change.
rlmoser99
approved these changes
Mar 31, 2025
painooo
pushed a commit
to painooo/ruby-exercises
that referenced
this pull request
Dec 29, 2025
PR template: remove mention of `solutions` branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
With #109, the solutions to the exercises in this repo have been moved from their own branch to the top-level
solutionsdirectory in themainbranch. Therefore mention of the unusedsolutionsbranch should be removed from the PR template.This PR
solutionsbranch in PR templateIssue
Closes #XXXXX
Additional Information
Pull Request Requirements
location of change: brief description of changeformat, e.g.Data types exercise: Update spec filesBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection