Skip to content

PR template: remove mention of solutions branch #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoshDevHub merged 2 commits into from
Apr 9, 2025
Merged

PR template: remove mention of solutions branch #113

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
926672f
Remove mention of `solutions` branch in PR template
JoshDevHub Nov 19, 2024
22d20d1
Instruct learners to be wary of changes needed in `solutions/`
JoshDevHub Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,4 @@ Closes #XXXXX
- [ ] The `Because` section summarizes the reason for this PR
- [ ] The `This PR` section has a bullet point list describing the changes in this PR
- [ ] If this PR addresses an open issue, it is linked in the `Issue` section
- [ ] If this PR includes changes that needs to be updated on the `solutions` branch, I have created another PR (and linked it to this PR).
Copy link
Copy Markdown
Member

@rlmoser99 rlmoser99 Dec 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should change this to something like this, because the purpose of this is to remind people that they may have to make changes in two places.

[ ] If this PR includes changes to exercises, they are also changed in the `solutions` folder.

Copy link
Copy Markdown
Contributor Author

@JoshDevHub JoshDevHub Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this makes perfect sense. I'll make the change.

- [ ] If this PR includes changes to exercises, they are also changed in the `solutions` folder.