Hotfix vc-less o3 doesn't count for 1.5 quota#704
Merged
Conversation
Fixed capitalization error that was preventing vc-less o3's from getting counted for 1.5 quota
Ragviswa
suggested changes
Feb 8, 2024
Contributor
Ragviswa
left a comment
Ragviswa
left a comment
There was a problem hiding this comment.
It looks like the VC-less Exalted variant, is named VC-less Exalted Oryx 3. The other variant is called VC-less Oryx 3 though. Just want to double-check the naming.
Also, I know it's annoying, but do you mind creating issues for PRs (even if they are small). If it's back-to-back changes on the same issue, like a hot fix to an PR that was recently merged, then it's not needed. But in this case, it has been a while since the original PRs. I'll create the issue for it this time, so no need to worry about it.
Template Screenshot:
3 tasks
2 tasks
fix quota values for o3, changed behavior in a way that should be more futureproof
Fixed bug with raid selection, made it dumber
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ViBot [8.12.13]
Changelog
Bugs
Summary
Overview
I'll be honest I plan to change the way quota is logged when I do my parsing rework, so this is just a temp fix. I know the current system is janky.