[pep8] tofu/geom/_core.py in pep8 conventions#236
Merged
Conversation
|
Hello @lasofivec! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-11-05 08:45:35 UTC |
Codecov Report
@@ Coverage Diff @@
## devel #236 +/- ##
==========================================
+ Coverage 43.94% 43.95% +0.01%
==========================================
Files 70 70
Lines 21290 21278 -12
==========================================
- Hits 9355 9352 -3
+ Misses 11935 11926 -9
Continue to review full report at Codecov.
|
lasofivec
commented
Nov 5, 2019
| def I(self): | ||
| return self._dmag["I"] | ||
| def current(self): | ||
| return self._dmag["current"] |
Collaborator
Author
There was a problem hiding this comment.
such a better name, thank you :)
Collaborator
Author
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to close Issue #190 and Issue #30 and to be able to delete this branch, @Didou09 could you please look into the details in the latest post of #190 ?
PS: I added the bug labels since this are probably undetected bugs