Issue202 spectro x2 d crystal by Didou09 · Pull Request #267 · ToFuProject/tofu

Didou09 · 2019-11-20T14:12:36Z

Main changes

tofu.geom._core_new.py created with new CrystalBragg class created , with operation plotting, moving and lamb<->bragg computing routines operational
tofu/geom._comp_new.py module created to hold all lamb<->bragg and spatial projection routines (crystal to plane via cones)
_spectralfitd.py created to handle all 2d multigaussian and b-spline fitting routines (being finished)

Incorporates the first elements of Issues #202 and #263 into devel

… multi ellipse fitting before re-sampled 2d fitting with known x0(y) and bsplines for y

…ne for spectral fits (Notes_Upgrades)

…tes) => try with crystal method

…cluding local plot from geom to ellipses, to be continued

…ansform => to be tested and validated in code

…> reveals probable errors in analytical calculations in Notes/SpectroX2D... to be recalculated with an alternative method

…directions, successfull but need to check bragg vs theta and ang_param vs epsilon (axis vs center), to test and validate

…s.py

…irections with proper parameters (bragg,angle) vs (xi, xj), tested and validated => optimize numerically or start testing on real data

… moved later to units tests

…annotated), for computing default geom parameters from bragg and curve radius, operational but results from calc_braggangle_from_xixj() not consistent: to be checked and then tested with experimental data

…be finished and tested

…onal => need to test with lambda => need to test crystal instanciation

… tested, surface computed, add rotation axis in dgeom and angle, add other crystals, try plotting fitted data

… nout + nin property to preserve (e1, e2, nout) direct orthonormal frame, ann to update Notes_Upgrades based on this and an arbitraty frame for the crystal

…ates

…t2d.py and start XICS data treatment in separate project, using tofu

…rystal

…consistency with other classes and retor-compatibility

…rameterizing with lamb0 optionally forced

…roject/tofu into Issue202_SpectroX2DCrystal

…rystal

…vide jacobian using BSplines.basis_element()

…east_squares(), but giving wrong results, maybe erro in jacobian or func ?

… data (choose indices)

…gma and delta common to same-ion lines + re-sample on less points using 2d Bsplines + adjust geometry + write same functions for 1d and 2d

…d on dlines and grouped by ions for sigma/dlamb, to be continued

…it2d.py

…d branch into devel for release 1.4.2

pep8speaks · 2019-11-20T14:12:46Z

Hello @Didou09! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file tofu/data/_spectrafit2d.py:

Line 49:5: E306 expected 1 blank line before a nested definition, found 0
Line 65:57: E231 missing whitespace after ','
Line 65:62: E225 missing whitespace around operator
Line 69:56: E231 missing whitespace after ','
Line 69:61: E225 missing whitespace around operator
Line 73:21: E225 missing whitespace around operator
Line 77:13: E129 visually indented line with same indent as next logical line
Line 83:37: E261 at least two spaces before inline comment
Line 83:37: E262 inline comment should start with '# '
Line 88:80: E501 line too long (83 > 79 characters)
Line 102:9: E303 too many blank lines (2)
Line 105:1: E302 expected 2 blank lines, found 1
Line 118:45: E231 missing whitespace after ','
Line 125:28: E225 missing whitespace around operator
Line 132:1: E302 expected 2 blank lines, found 1
Line 148:45: E231 missing whitespace after ','
Line 154:28: E225 missing whitespace around operator
Line 170:42: E225 missing whitespace around operator
Line 231:34: E127 continuation line over-indented for visual indent
Line 250:5: E303 too many blank lines (2)
Line 252:37: E231 missing whitespace after ','
Line 269:61: E231 missing whitespace after ','
Line 270:47: E128 continuation line under-indented for visual indent
Line 307:8: E714 test for object identity should be 'is not'
Line 317:38: E228 missing whitespace around modulo operator
Line 317:43: E225 missing whitespace around operator
Line 321:66: E231 missing whitespace after ','
Line 329:33: E228 missing whitespace around modulo operator
Line 333:59: E231 missing whitespace after ','
Line 335:70: E231 missing whitespace after ','
Line 342:70: E231 missing whitespace after ','
Line 362:22: E231 missing whitespace after ','
Line 362:38: E231 missing whitespace after ','
Line 362:54: E231 missing whitespace after ','
Line 366:35: E231 missing whitespace after ','
Line 367:38: E231 missing whitespace after ','
Line 367:48: E231 missing whitespace after ','
Line 367:61: E231 missing whitespace after ','
Line 370:32: E231 missing whitespace after ','
Line 370:34: E231 missing whitespace after ','
Line 371:32: E231 missing whitespace after ','
Line 371:34: E231 missing whitespace after ','
Line 372:23: E231 missing whitespace after ','
Line 372:34: E231 missing whitespace after ','
Line 388:1: E303 too many blank lines (3)
Line 397:1: E302 expected 2 blank lines, found 3
Line 400:24: E128 continuation line under-indented for visual indent
Line 415:10: E225 missing whitespace around operator
Line 416:19: E231 missing whitespace after ':'
Line 488:1: E303 too many blank lines (4)
Line 510:1: E303 too many blank lines (10)
Line 518:1: E302 expected 2 blank lines, found 10
Line 562:46: E231 missing whitespace after ','
Line 562:48: E231 missing whitespace after ','
Line 563:48: E231 missing whitespace after ','
Line 563:53: E231 missing whitespace after ','
Line 565:41: E225 missing whitespace around operator
Line 565:59: E231 missing whitespace after ','
Line 565:61: E231 missing whitespace after ','
Line 573:41: E225 missing whitespace around operator
Line 609:36: E225 missing whitespace around operator
Line 621:13: E265 block comment should start with '# '
Line 630:21: E265 block comment should start with '# '
Line 647:80: E501 line too long (80 > 79 characters)
Line 649:80: E501 line too long (80 > 79 characters)
Line 652:80: E501 line too long (81 > 79 characters)
Line 653:35: E128 continuation line under-indented for visual indent
Line 657:51: E703 statement ends with a semicolon
Line 658:41: E231 missing whitespace after ','
Line 658:46: E231 missing whitespace after ','
Line 658:51: E231 missing whitespace after ','
Line 659:41: E231 missing whitespace after ','
Line 659:46: E231 missing whitespace after ','
Line 659:51: E231 missing whitespace after ','
Line 659:80: E501 line too long (80 > 79 characters)
Line 660:41: E231 missing whitespace after ','
Line 660:46: E231 missing whitespace after ','
Line 660:51: E231 missing whitespace after ','
Line 660:80: E501 line too long (80 > 79 characters)
Line 661:41: E231 missing whitespace after ','
Line 661:46: E231 missing whitespace after ','
Line 661:51: E231 missing whitespace after ','
Line 661:80: E501 line too long (80 > 79 characters)
Line 662:41: E231 missing whitespace after ','
Line 662:46: E231 missing whitespace after ','
Line 662:51: E231 missing whitespace after ','
Line 662:80: E501 line too long (80 > 79 characters)
Line 663:41: E231 missing whitespace after ','
Line 663:46: E231 missing whitespace after ','
Line 663:51: E231 missing whitespace after ','
Line 663:80: E501 line too long (80 > 79 characters)
Line 664:80: E501 line too long (82 > 79 characters)
Line 665:28: E128 continuation line under-indented for visual indent
Line 666:80: E501 line too long (87 > 79 characters)
Line 667:28: E128 continuation line under-indented for visual indent
Line 671:80: E501 line too long (81 > 79 characters)
Line 680:80: E501 line too long (83 > 79 characters)
Line 681:80: E501 line too long (83 > 79 characters)
Line 696:13: E265 block comment should start with '# '
Line 723:1: E302 expected 2 blank lines, found 1
Line 823:68: E231 missing whitespace after ':'
Line 824:18: E231 missing whitespace after ':'
Line 825:20: E231 missing whitespace after ':'
Line 825:49: E231 missing whitespace after ':'
Line 833:1: E303 too many blank lines (4)
Line 842:1: E302 expected 2 blank lines, found 4
Line 846:46: E231 missing whitespace after ','
Line 846:80: E501 line too long (81 > 79 characters)
Line 849:14: E231 missing whitespace after ','
Line 849:28: E231 missing whitespace after ','
Line 857:18: E231 missing whitespace after ','
Line 857:32: E231 missing whitespace after ','
Line 858:51: E231 missing whitespace after ','
Line 858:54: E231 missing whitespace after ','
Line 858:64: E231 missing whitespace after ','
Line 858:67: E231 missing whitespace after ','
Line 859:56: E231 missing whitespace after ','
Line 859:59: E231 missing whitespace after ','
Line 867:1: E303 too many blank lines (3)
Line 868:27: E231 missing whitespace after ','
Line 870:5: E306 expected 1 blank line before a nested definition, found 0
Line 880:1: E303 too many blank lines (3)
Line 898:27: E231 missing whitespace after ','
Line 900:29: E231 missing whitespace after ','
Line 900:43: E231 missing whitespace after ','
Line 902:25: E231 missing whitespace after ','
Line 916:20: E231 missing whitespace after ','
Line 965:5: E303 too many blank lines (2)
Line 976:5: E303 too many blank lines (2)
Line 983:5: E303 too many blank lines (2)
Line 992:5: E303 too many blank lines (4)
Line 997:14: E222 multiple spaces after operator
Line 1002:13: E117 over-indented
Line 1002:45: E231 missing whitespace after ','
Line 1002:47: E231 missing whitespace after ','
Line 1004:34: E231 missing whitespace after ','
Line 1004:43: E231 missing whitespace after ','
Line 1005:39: E231 missing whitespace after ','
Line 1005:48: E231 missing whitespace after ','
Line 1006:42: E231 missing whitespace after ','
Line 1006:51: E231 missing whitespace after ','
Line 1007:35: E231 missing whitespace after ','
Line 1009:34: E231 missing whitespace after ','
Line 1009:43: E231 missing whitespace after ','
Line 1010:39: E231 missing whitespace after ','
Line 1010:48: E231 missing whitespace after ','
Line 1011:42: E231 missing whitespace after ','
Line 1011:51: E231 missing whitespace after ','
Line 1012:35: E231 missing whitespace after ','
Line 1015:5: E303 too many blank lines (2)
Line 1015:27: E201 whitespace after '('
Line 1028:1: E303 too many blank lines (3)
Line 1029:13: E116 unexpected indentation (comment)
Line 1030:13: E116 unexpected indentation (comment)
Line 1031:13: E116 unexpected indentation (comment)
Line 1032:13: E116 unexpected indentation (comment)
Line 1033:13: E116 unexpected indentation (comment)
Line 1034:13: E116 unexpected indentation (comment)
Line 1037:23: E114 indentation is not a multiple of four (comment)
Line 1037:23: E116 unexpected indentation (comment)
Line 1048:9: E116 unexpected indentation (comment)
Line 1049:9: E116 unexpected indentation (comment)
Line 1050:13: E116 unexpected indentation (comment)
Line 1051:9: E116 unexpected indentation (comment)
Line 1052:13: E116 unexpected indentation (comment)
Line 1053:9: E116 unexpected indentation (comment)
Line 1054:13: E116 unexpected indentation (comment)
Line 1055:49: E116 unexpected indentation (comment)
Line 1056:9: E116 unexpected indentation (comment)
Line 1057:13: E116 unexpected indentation (comment)
Line 1058:13: E116 unexpected indentation (comment)
Line 1060:9: E116 unexpected indentation (comment)
Line 1061:9: E116 unexpected indentation (comment)
Line 1062:9: E116 unexpected indentation (comment)
Line 1063:9: E116 unexpected indentation (comment)
Line 1064:9: E116 unexpected indentation (comment)
Line 1065:13: E116 unexpected indentation (comment)
Line 1066:40: E114 indentation is not a multiple of four (comment)
Line 1066:40: E116 unexpected indentation (comment)
Line 1067:9: E116 unexpected indentation (comment)
Line 1068:9: E116 unexpected indentation (comment)
Line 1069:9: E116 unexpected indentation (comment)
Line 1071:9: E116 unexpected indentation (comment)
Line 1072:9: E116 unexpected indentation (comment)
Line 1073:13: E116 unexpected indentation (comment)
Line 1074:17: E116 unexpected indentation (comment)
Line 1075:17: E116 unexpected indentation (comment)
Line 1076:17: E116 unexpected indentation (comment)
Line 1077:17: E116 unexpected indentation (comment)
Line 1078:17: E116 unexpected indentation (comment)
Line 1079:21: E116 unexpected indentation (comment)
Line 1080:21: E116 unexpected indentation (comment)
Line 1081:21: E116 unexpected indentation (comment)
Line 1082:17: E116 unexpected indentation (comment)
Line 1083:13: E116 unexpected indentation (comment)
Line 1084:17: E116 unexpected indentation (comment)
Line 1091:11: E114 indentation is not a multiple of four (comment)
Line 1091:11: E116 unexpected indentation (comment)
Line 1092:11: E114 indentation is not a multiple of four (comment)
Line 1092:11: E116 unexpected indentation (comment)
Line 1095:9: E116 unexpected indentation (comment)
Line 1096:9: E116 unexpected indentation (comment)
Line 1100:9: E116 unexpected indentation (comment)
Line 1101:9: E116 unexpected indentation (comment)
Line 1102:9: E116 unexpected indentation (comment)
Line 1103:9: E116 unexpected indentation (comment)
Line 1104:9: E116 unexpected indentation (comment)
Line 1105:9: E116 unexpected indentation (comment)
Line 1106:9: E116 unexpected indentation (comment)
Line 1107:9: E116 unexpected indentation (comment)
Line 1108:9: E116 unexpected indentation (comment)
Line 1109:9: E116 unexpected indentation (comment)
Line 1110:9: E116 unexpected indentation (comment)
Line 1114:9: E116 unexpected indentation (comment)
Line 1115:9: E116 unexpected indentation (comment)
Line 1116:9: E116 unexpected indentation (comment)
Line 1117:9: E116 unexpected indentation (comment)
Line 1118:13: E116 unexpected indentation (comment)
Line 1119:13: E116 unexpected indentation (comment)
Line 1120:9: E116 unexpected indentation (comment)
Line 1121:13: E116 unexpected indentation (comment)
Line 1122:13: E116 unexpected indentation (comment)
Line 1123:13: E116 unexpected indentation (comment)
Line 1128:1: E303 too many blank lines (3)
Line 1149:9: E116 unexpected indentation (comment)
Line 1150:9: E116 unexpected indentation (comment)
Line 1151:9: E116 unexpected indentation (comment)
Line 1152:9: E116 unexpected indentation (comment)
Line 1153:9: E116 unexpected indentation (comment)
Line 1160:9: E116 unexpected indentation (comment)
Line 1161:9: E116 unexpected indentation (comment)
Line 1162:9: E116 unexpected indentation (comment)
Line 1163:13: E116 unexpected indentation (comment)
Line 1164:22: E114 indentation is not a multiple of four (comment)
Line 1164:22: E116 unexpected indentation (comment)
Line 1165:9: E116 unexpected indentation (comment)
Line 1166:13: E116 unexpected indentation (comment)
Line 1167:9: E116 unexpected indentation (comment)
Line 1168:13: E116 unexpected indentation (comment)
Line 1169:9: E116 unexpected indentation (comment)
Line 1170:13: E116 unexpected indentation (comment)
Line 1171:9: E116 unexpected indentation (comment)
Line 1172:9: E116 unexpected indentation (comment)
Line 1173:9: E116 unexpected indentation (comment)
Line 1174:9: E116 unexpected indentation (comment)
Line 1175:9: E116 unexpected indentation (comment)
Line 1176:13: E116 unexpected indentation (comment)
Line 1177:13: E116 unexpected indentation (comment)
Line 1178:13: E116 unexpected indentation (comment)
Line 1179:9: E116 unexpected indentation (comment)
Line 1180:13: E116 unexpected indentation (comment)
Line 1181:13: E116 unexpected indentation (comment)
Line 1182:9: E116 unexpected indentation (comment)
Line 1183:9: E116 unexpected indentation (comment)
Line 1184:19: E114 indentation is not a multiple of four (comment)
Line 1184:19: E116 unexpected indentation (comment)
Line 1185:9: E116 unexpected indentation (comment)
Line 1186:13: E116 unexpected indentation (comment)
Line 1187:48: E114 indentation is not a multiple of four (comment)
Line 1187:48: E116 unexpected indentation (comment)
Line 1187:80: E501 line too long (85 > 79 characters)
Line 1188:48: E114 indentation is not a multiple of four (comment)
Line 1188:48: E116 unexpected indentation (comment)
Line 1189:9: E116 unexpected indentation (comment)
Line 1190:13: E116 unexpected indentation (comment)
Line 1191:13: E116 unexpected indentation (comment)
Line 1192:13: E116 unexpected indentation (comment)
Line 1193:13: E116 unexpected indentation (comment)
Line 1195:9: E116 unexpected indentation (comment)
Line 1196:9: E116 unexpected indentation (comment)
Line 1197:9: E116 unexpected indentation (comment)
Line 1198:9: E116 unexpected indentation (comment)
Line 1201:9: E116 unexpected indentation (comment)
Line 1201:9: E303 too many blank lines (2)
Line 1221:15: E114 indentation is not a multiple of four (comment)
Line 1221:15: E116 unexpected indentation (comment)
Line 1223:9: E116 unexpected indentation (comment)
Line 1224:9: E116 unexpected indentation (comment)
Line 1225:9: E116 unexpected indentation (comment)
Line 1226:9: E116 unexpected indentation (comment)
Line 1232:9: E116 unexpected indentation (comment)
Line 1233:9: E116 unexpected indentation (comment)
Line 1234:13: E116 unexpected indentation (comment)
Line 1235:9: E116 unexpected indentation (comment)
Line 1236:9: E116 unexpected indentation (comment)
Line 1239:9: E116 unexpected indentation (comment)
Line 1240:9: E116 unexpected indentation (comment)
Line 1241:9: E116 unexpected indentation (comment)
Line 1242:9: E116 unexpected indentation (comment)
Line 1243:9: E116 unexpected indentation (comment)
Line 1243:80: E501 line too long (102 > 79 characters)
Line 1244:9: E116 unexpected indentation (comment)
Line 1245:9: E116 unexpected indentation (comment)
Line 1248:9: E116 unexpected indentation (comment)
Line 1249:9: E116 unexpected indentation (comment)
Line 1250:9: E116 unexpected indentation (comment)
Line 1251:9: E116 unexpected indentation (comment)
Line 1252:9: E116 unexpected indentation (comment)
Line 1253:9: E116 unexpected indentation (comment)
Line 1254:9: E116 unexpected indentation (comment)
Line 1254:80: E501 line too long (104 > 79 characters)
Line 1255:9: E116 unexpected indentation (comment)
Line 1255:80: E501 line too long (107 > 79 characters)
Line 1256:9: E116 unexpected indentation (comment)
Line 1257:9: E116 unexpected indentation (comment)
Line 1263:25: E116 unexpected indentation (comment)
Line 1264:25: E116 unexpected indentation (comment)
Line 1268:9: E116 unexpected indentation (comment)
Line 1283:9: E116 unexpected indentation (comment)
Line 1289:9: E116 unexpected indentation (comment)
Line 1291:9: E116 unexpected indentation (comment)
Line 1293:9: E116 unexpected indentation (comment)
Line 1300:9: E116 unexpected indentation (comment)
Line 1301:13: E116 unexpected indentation (comment)
Line 1303:9: E116 unexpected indentation (comment)
Line 1304:13: E116 unexpected indentation (comment)
Line 1305:43: E114 indentation is not a multiple of four (comment)
Line 1305:43: E116 unexpected indentation (comment)
Line 1306:43: E114 indentation is not a multiple of four (comment)
Line 1306:43: E116 unexpected indentation (comment)
Line 1307:43: E114 indentation is not a multiple of four (comment)
Line 1307:43: E116 unexpected indentation (comment)
Line 1308:43: E114 indentation is not a multiple of four (comment)
Line 1308:43: E116 unexpected indentation (comment)
Line 1309:43: E114 indentation is not a multiple of four (comment)
Line 1309:43: E116 unexpected indentation (comment)
Line 1310:9: E116 unexpected indentation (comment)
Line 1311:13: E116 unexpected indentation (comment)
Line 1312:13: E116 unexpected indentation (comment)
Line 1313:13: E116 unexpected indentation (comment)
Line 1314:13: E116 unexpected indentation (comment)
Line 1315:13: E116 unexpected indentation (comment)
Line 1316:17: E116 unexpected indentation (comment)
Line 1317:17: E116 unexpected indentation (comment)
Line 1318:47: E114 indentation is not a multiple of four (comment)
Line 1318:47: E116 unexpected indentation (comment)
Line 1319:47: E114 indentation is not a multiple of four (comment)
Line 1319:47: E116 unexpected indentation (comment)
Line 1320:47: E114 indentation is not a multiple of four (comment)
Line 1320:47: E116 unexpected indentation (comment)
Line 1321:47: E114 indentation is not a multiple of four (comment)
Line 1321:47: E116 unexpected indentation (comment)
Line 1322:47: E114 indentation is not a multiple of four (comment)
Line 1322:47: E116 unexpected indentation (comment)
Line 1323:17: E116 unexpected indentation (comment)
Line 1324:17: E116 unexpected indentation (comment)
Line 1325:47: E114 indentation is not a multiple of four (comment)
Line 1325:47: E116 unexpected indentation (comment)
Line 1326:47: E114 indentation is not a multiple of four (comment)
Line 1326:47: E116 unexpected indentation (comment)
Line 1327:47: E114 indentation is not a multiple of four (comment)
Line 1327:47: E116 unexpected indentation (comment)
Line 1328:47: E114 indentation is not a multiple of four (comment)
Line 1328:47: E116 unexpected indentation (comment)
Line 1329:47: E114 indentation is not a multiple of four (comment)
Line 1329:47: E116 unexpected indentation (comment)
Line 1330:17: E116 unexpected indentation (comment)
Line 1331:13: E116 unexpected indentation (comment)
Line 1332:17: E116 unexpected indentation (comment)
Line 1333:17: E116 unexpected indentation (comment)
Line 1334:17: E116 unexpected indentation (comment)
Line 1335:17: E116 unexpected indentation (comment)
Line 1338:9: E116 unexpected indentation (comment)
Line 1338:9: E303 too many blank lines (2)
Line 1339:9: E116 unexpected indentation (comment)
Line 1340:9: E116 unexpected indentation (comment)
Line 1341:9: E116 unexpected indentation (comment)
Line 1343:9: E116 unexpected indentation (comment)
Line 1344:9: E116 unexpected indentation (comment)
Line 1345:9: E116 unexpected indentation (comment)
Line 1346:9: E116 unexpected indentation (comment)
Line 1347:9: E116 unexpected indentation (comment)
Line 1348:9: E116 unexpected indentation (comment)
Line 1350:9: E116 unexpected indentation (comment)
Line 1352:9: E116 unexpected indentation (comment)
Line 1353:13: E116 unexpected indentation (comment)
Line 1355:13: E116 unexpected indentation (comment)
Line 1356:13: E116 unexpected indentation (comment)
Line 1357:13: E116 unexpected indentation (comment)
Line 1358:13: E116 unexpected indentation (comment)
Line 1359:22: E114 indentation is not a multiple of four (comment)
Line 1359:22: E116 unexpected indentation (comment)
Line 1360:13: E116 unexpected indentation (comment)
Line 1366:1: E303 too many blank lines (3)
Line 1367:22: E114 indentation is not a multiple of four (comment)
Line 1367:22: E116 unexpected indentation (comment)
Line 1372:9: E116 unexpected indentation (comment)
Line 1373:9: E116 unexpected indentation (comment)
Line 1374:13: E116 unexpected indentation (comment)
Line 1375:9: E116 unexpected indentation (comment)
Line 1376:9: E116 unexpected indentation (comment)
Line 1377:9: E116 unexpected indentation (comment)
Line 1378:13: E116 unexpected indentation (comment)
Line 1379:17: E116 unexpected indentation (comment)
Line 1379:80: E501 line too long (81 > 79 characters)
Line 1381:9: E116 unexpected indentation (comment)
Line 1382:9: E116 unexpected indentation (comment)
Line 1385:5: E303 too many blank lines (2)
Line 1390:56: E114 indentation is not a multiple of four (comment)
Line 1390:56: E116 unexpected indentation (comment)
Line 1390:80: E501 line too long (84 > 79 characters)
Line 1391:56: E114 indentation is not a multiple of four (comment)
Line 1391:56: E116 unexpected indentation (comment)
Line 1407:9: E116 unexpected indentation (comment)
Line 1410:9: E116 unexpected indentation (comment)
Line 1411:9: E116 unexpected indentation (comment)
Line 1412:9: E116 unexpected indentation (comment)
Line 1413:9: E116 unexpected indentation (comment)
Line 1414:9: E116 unexpected indentation (comment)
Line 1420:1: E303 too many blank lines (3)
Line 1427:21: E116 unexpected indentation (comment)
Line 1457:16: E114 indentation is not a multiple of four (comment)
Line 1457:16: E116 unexpected indentation (comment)
Line 1458:16: E114 indentation is not a multiple of four (comment)
Line 1458:16: E116 unexpected indentation (comment)
Line 1459:16: E114 indentation is not a multiple of four (comment)
Line 1459:16: E116 unexpected indentation (comment)
Line 1466:9: E116 unexpected indentation (comment)
Line 1467:19: E114 indentation is not a multiple of four (comment)
Line 1467:19: E116 unexpected indentation (comment)
Line 1468:9: E116 unexpected indentation (comment)
Line 1469:13: E116 unexpected indentation (comment)
Line 1470:13: E116 unexpected indentation (comment)
Line 1471:13: E116 unexpected indentation (comment)
Line 1472:31: E114 indentation is not a multiple of four (comment)
Line 1472:31: E116 unexpected indentation (comment)
Line 1473:31: E114 indentation is not a multiple of four (comment)
Line 1473:31: E116 unexpected indentation (comment)
Line 1474:31: E114 indentation is not a multiple of four (comment)
Line 1474:31: E116 unexpected indentation (comment)
Line 1475:13: E116 unexpected indentation (comment)
Line 1476:17: E116 unexpected indentation (comment)
Line 1477:17: E116 unexpected indentation (comment)
Line 1478:17: E116 unexpected indentation (comment)
Line 1479:17: E116 unexpected indentation (comment)
Line 1480:17: E116 unexpected indentation (comment)
Line 1481:17: E116 unexpected indentation (comment)

In the file tofu/geom/_comp_optics.py:

Line 15:1: E302 expected 2 blank lines, found 1
Line 28:1: E302 expected 2 blank lines, found 1
Line 34:80: E501 line too long (86 > 79 characters)
Line 42:1: E302 expected 2 blank lines, found 1
Line 55:1: E302 expected 2 blank lines, found 1
Line 92:10: E225 missing whitespace around operator
Line 98:1: E302 expected 2 blank lines, found 1
Line 119:1: E302 expected 2 blank lines, found 1
Line 124:17: E127 continuation line over-indented for visual indent
Line 147:1: E302 expected 2 blank lines, found 1
Line 158:1: E302 expected 2 blank lines, found 1
Line 171:1: E302 expected 2 blank lines, found 1
Line 188:5: E303 too many blank lines (2)
Line 197:1: E302 expected 2 blank lines, found 1
Line 199:27: E225 missing whitespace around operator

In the file tofu/geom/_core.py:

Line 4095:80: E501 line too long (81 > 79 characters)
Line 4986:5: E129 visually indented line with same indent as next logical line

In the file tofu/geom/_core_optics.py:

Line 4:80: E501 line too long (81 > 79 characters)
Line 37:1: E303 too many blank lines (3)
Line 41:1: E303 too many blank lines (3)
Line 53:1: E303 too many blank lines (3)
Line 81:18: E231 missing whitespace after ':'
Line 82:29: E231 missing whitespace after ':'
Line 84:21: E231 missing whitespace after ':'
Line 85:20: E231 missing whitespace after ':'
Line 86:22: E231 missing whitespace after ':'
Line 87:21: E231 missing whitespace after ':'
Line 87:30: E231 missing whitespace after ':'
Line 88:22: E231 missing whitespace after ':'
Line 88:29: E231 missing whitespace after ':'
Line 89:28: E231 missing whitespace after ':'
Line 89:37: E231 missing whitespace after ':'
Line 89:41: E231 missing whitespace after ','
Line 89:46: E231 missing whitespace after ':'
Line 90:28: E231 missing whitespace after ':'
Line 90:37: E231 missing whitespace after ':'
Line 90:41: E231 missing whitespace after ','
Line 90:46: E231 missing whitespace after ':'
Line 90:51: E231 missing whitespace after ','
Line 90:60: E231 missing whitespace after ':'
Line 90:64: E231 missing whitespace after ','
Line 90:69: E231 missing whitespace after ':'
Line 90:71: E231 missing whitespace after ','
Line 90:77: E231 missing whitespace after ':'
Line 90:80: E501 line too long (80 > 79 characters)
Line 91:29: E231 missing whitespace after ':'
Line 91:38: E231 missing whitespace after ':'
Line 91:42: E231 missing whitespace after ','
Line 91:47: E231 missing whitespace after ':'
Line 91:52: E231 missing whitespace after ','
Line 91:61: E231 missing whitespace after ':'
Line 91:65: E231 missing whitespace after ','
Line 91:70: E231 missing whitespace after ':'
Line 91:72: E231 missing whitespace after ','
Line 91:78: E231 missing whitespace after ':'
Line 91:80: E501 line too long (81 > 79 characters)
Line 92:29: E231 missing whitespace after ':'
Line 92:38: E231 missing whitespace after ':'
Line 92:42: E231 missing whitespace after ','
Line 92:47: E231 missing whitespace after ':'
Line 92:52: E231 missing whitespace after ','
Line 92:61: E231 missing whitespace after ':'
Line 92:65: E231 missing whitespace after ','
Line 92:70: E231 missing whitespace after ':'
Line 92:72: E231 missing whitespace after ','
Line 92:78: E231 missing whitespace after ':'
Line 92:80: E501 line too long (81 > 79 characters)
Line 93:31: E231 missing whitespace after ':'
Line 93:40: E231 missing whitespace after ':'
Line 93:44: E231 missing whitespace after ','
Line 93:52: E231 missing whitespace after ':'
Line 94:20: E231 missing whitespace after ':'
Line 94:27: E231 missing whitespace after ':'
Line 95:26: E231 missing whitespace after ':'
Line 95:35: E231 missing whitespace after ':'
Line 95:39: E231 missing whitespace after ','
Line 95:44: E231 missing whitespace after ':'
Line 96:26: E231 missing whitespace after ':'
Line 96:35: E231 missing whitespace after ':'
Line 96:39: E231 missing whitespace after ','
Line 96:44: E231 missing whitespace after ':'
Line 97:27: E231 missing whitespace after ':'
Line 97:36: E231 missing whitespace after ':'
Line 97:40: E231 missing whitespace after ','
Line 97:45: E231 missing whitespace after ':'
Line 98:27: E231 missing whitespace after ':'
Line 98:36: E231 missing whitespace after ':'
Line 98:40: E231 missing whitespace after ','
Line 98:45: E231 missing whitespace after ':'
Line 99:29: E231 missing whitespace after ':'
Line 100:19: E231 missing whitespace after ':'
Line 107:5: E303 too many blank lines (2)
Line 108:5: E301 expected 1 blank line, found 0
Line 110:27: E231 missing whitespace after ','
Line 112:9: E265 block comment should start with '# '
Line 128:26: E225 missing whitespace around operator
Line 138:27: E231 missing whitespace after ','
Line 142:27: E231 missing whitespace after ','
Line 147:9: E265 block comment should start with '# '
Line 155:33: E231 missing whitespace after ','
Line 168:23: E231 missing whitespace after ':'
Line 168:30: E231 missing whitespace after ':'
Line 168:42: E231 missing whitespace after ':'
Line 169:30: E231 missing whitespace after ':'
Line 169:41: E231 missing whitespace after ':'
Line 170:31: E231 missing whitespace after ':'
Line 170:43: E231 missing whitespace after ':'
Line 171:31: E231 missing whitespace after ':'
Line 171:43: E231 missing whitespace after ':'
Line 172:31: E231 missing whitespace after ':'
Line 172:42: E231 missing whitespace after ':'
Line 173:26: E231 missing whitespace after ':'
Line 173:33: E231 missing whitespace after ':'
Line 173:51: E231 missing whitespace after ':'
Line 178:31: E231 missing whitespace after ':'
Line 178:44: E231 missing whitespace after ':'
Line 179:30: E231 missing whitespace after ':'
Line 179:42: E231 missing whitespace after ':'
Line 179:55: E231 missing whitespace after ':'
Line 180:34: E231 missing whitespace after ':'
Line 271:20: E231 missing whitespace after ','
Line 271:33: E231 missing whitespace after ','
Line 271:61: E231 missing whitespace after ','
Line 391:80: E501 line too long (80 > 79 characters)
Line 393:80: E501 line too long (81 > 79 characters)
Line 481:36: E231 missing whitespace after ','
Line 485:60: E231 missing whitespace after ','
Line 486:26: E225 missing whitespace around operator
Line 496:17: E225 missing whitespace around operator
Line 508:24: E231 missing whitespace after ':'
Line 508:32: E231 missing whitespace after ':'
Line 508:55: E231 missing whitespace after ':'
Line 509:23: E231 missing whitespace after ':'
Line 509:31: E231 missing whitespace after ':'
Line 509:53: E231 missing whitespace after ':'
Line 510:25: E231 missing whitespace after ':'
Line 510:33: E231 missing whitespace after ':'
Line 510:57: E231 missing whitespace after ':'
Line 511:24: E231 missing whitespace after ':'
Line 511:32: E231 missing whitespace after ':'
Line 511:55: E231 missing whitespace after ':'
Line 512:24: E231 missing whitespace after ':'
Line 512:32: E231 missing whitespace after ':'
Line 512:55: E231 missing whitespace after ':'
Line 594:45: E228 missing whitespace around modulo operator
Line 623:34: E712 comparison to False should be 'if cond is not False:' or 'if cond:'
Line 629:80: E501 line too long (80 > 79 characters)
Line 633:35: E127 continuation line over-indented for visual indent
Line 634:35: E127 continuation line over-indented for visual indent
Line 648:5: E303 too many blank lines (2)
Line 655:58: E228 missing whitespace around modulo operator
Line 657:54: E228 missing whitespace around modulo operator
Line 682:55: E231 missing whitespace after ':'
Line 683:49: E231 missing whitespace after ':'
Line 687:34: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 705:80: E501 line too long (80 > 79 characters)
Line 726:5: E303 too many blank lines (3)
Line 730:5: E301 expected 1 blank line, found 0
Line 753:51: E228 missing whitespace around modulo operator
Line 754:51: E228 missing whitespace around modulo operator
Line 819:5: E303 too many blank lines (3)
Line 823:5: E301 expected 1 blank line, found 0
Line 881:38: E231 missing whitespace after ','
Line 908:5: E303 too many blank lines (2)
Line 1005:17: E712 comparison to False should be 'if cond is not False:' or 'if cond:'
Line 1018:29: E128 continuation line under-indented for visual indent
Line 1019:29: E128 continuation line under-indented for visual indent
Line 1020:29: E128 continuation line under-indented for visual indent
Line 1021:29: E128 continuation line under-indented for visual indent
Line 1040:48: E225 missing whitespace around operator
Line 1040:80: E501 line too long (80 > 79 characters)
Line 1077:48: E225 missing whitespace around operator
Line 1077:80: E501 line too long (80 > 79 characters)
Line 1096:42: E231 missing whitespace after ','
Line 1099:9: E303 too many blank lines (2)
Line 1103:80: E501 line too long (80 > 79 characters)
Line 1112:9: E303 too many blank lines (2)

In the file tofu/geom/_plot_optics.py:

Line 16:58: E228 missing whitespace around modulo operator
Line 16:80: E501 line too long (80 > 79 characters)
Line 57:37: E228 missing whitespace around modulo operator
Line 58:36: E228 missing whitespace around modulo operator
Line 71:80: E501 line too long (140 > 79 characters)
Line 78:54: E127 continuation line over-indented for visual indent
Line 79:26: E272 multiple spaces before keyword
Line 81:53: E128 continuation line under-indented for visual indent
Line 88:1: E303 too many blank lines (3)
Line 94:1: E302 expected 2 blank lines, found 3
Line 111:10: E111 indentation is not a multiple of four
Line 111:10: E117 over-indented
Line 121:80: E501 line too long (94 > 79 characters)
Line 136:12: E712 comparison to False should be 'if cond is not False:' or 'if cond:'
Line 142:1: E302 expected 2 blank lines, found 1
Line 142:80: E501 line too long (83 > 79 characters)
Line 143:80: E501 line too long (87 > 79 characters)
Line 154:80: E501 line too long (95 > 79 characters)
Line 195:46: E231 missing whitespace after ','
Line 195:57: E231 missing whitespace after ','
Line 195:69: E231 missing whitespace after ','
Line 199:35: E231 missing whitespace after ','
Line 199:46: E231 missing whitespace after ','
Line 222:45: E231 missing whitespace after ','
Line 222:55: E231 missing whitespace after ','
Line 222:66: E231 missing whitespace after ','
Line 226:34: E231 missing whitespace after ','
Line 226:44: E231 missing whitespace after ','
Line 232:30: E231 missing whitespace after ','
Line 235:46: E231 missing whitespace after ','
Line 235:55: E231 missing whitespace after ','
Line 235:65: E231 missing whitespace after ','
Line 236:45: E231 missing whitespace after ','
Line 236:53: E231 missing whitespace after ','
Line 236:62: E231 missing whitespace after ','
Line 241:35: E231 missing whitespace after ','
Line 241:44: E231 missing whitespace after ','
Line 242:34: E231 missing whitespace after ','
Line 242:42: E231 missing whitespace after ','
Line 265:27: E231 missing whitespace after ','
Line 265:31: E231 missing whitespace after ','
Line 265:35: E231 missing whitespace after ','
Line 270:37: E231 missing whitespace after ','
Line 270:39: E231 missing whitespace after ','
Line 271:36: E231 missing whitespace after ','
Line 271:38: E231 missing whitespace after ','
Line 288:31: E231 missing whitespace after ','
Line 288:35: E231 missing whitespace after ','
Line 288:39: E231 missing whitespace after ','
Line 291:14: E225 missing whitespace around operator
Line 292:21: E231 missing whitespace after ','
Line 292:31: E231 missing whitespace after ','
Line 292:58: E228 missing whitespace around modulo operator
Line 302:1: E303 too many blank lines (4)
Line 340:48: E228 missing whitespace around modulo operator
Line 341:37: E228 missing whitespace around modulo operator
Line 355:17: E231 missing whitespace after ','
Line 359:26: E231 missing whitespace after ':'
Line 359:40: E231 missing whitespace after ':'
Line 360:28: E231 missing whitespace after ':'
Line 360:40: E231 missing whitespace after ':'
Line 361:28: E231 missing whitespace after ':'
Line 361:43: E231 missing whitespace after ':'
Line 369:5: E303 too many blank lines (2)
Line 425:26: E231 missing whitespace after ':'
Line 425:40: E231 missing whitespace after ':'
Line 426:28: E231 missing whitespace after ':'
Line 426:40: E231 missing whitespace after ':'
Line 427:28: E231 missing whitespace after ':'
Line 427:43: E231 missing whitespace after ':'
Line 435:5: E303 too many blank lines (2)
Line 445:19: E225 missing whitespace around operator
Line 461:49: E261 at least two spaces before inline comment
Line 461:49: E262 inline comment should start with '# '
Line 463:49: E261 at least two spaces before inline comment
Line 463:49: E262 inline comment should start with '# '
Line 473:24: E228 missing whitespace around modulo operator
Line 507:25: E127 continuation line over-indented for visual indent
Line 510:66: E231 missing whitespace after ','
Line 510:80: E501 line too long (92 > 79 characters)
Line 511:66: E231 missing whitespace after ','
Line 511:80: E501 line too long (92 > 79 characters)
Line 518:80: E501 line too long (82 > 79 characters)
Line 520:66: E231 missing whitespace after ','
Line 520:80: E501 line too long (92 > 79 characters)
Line 521:80: E501 line too long (80 > 79 characters)
Line 522:41: E128 continuation line under-indented for visual indent

Comment last updated at 2019-11-20 15:11:00 UTC

codecov-io · 2019-11-20T14:22:59Z

Codecov Report

Merging #267 into devel will decrease coverage by 2.25%.
The diff coverage is 11.47%.

@@            Coverage Diff             @@
##            devel     #267      +/-   ##
==========================================
- Coverage   43.72%   41.47%   -2.26%     
==========================================
  Files          75       79       +4     
  Lines       21606    23217    +1611     
==========================================
+ Hits         9448     9629     +181     
- Misses      12158    13588    +1430

Impacted Files	Coverage Δ
tofu/geom/__init__.py	`100% <100%> (ø)`	⬆️
tofu/version.py	`100% <100%> (ø)`	⬆️
tofu/data/_core.py	`41.1% <100%> (+0.05%)`	⬆️
tofu/geom/_comp_optics.py	`12.82% <12.82%> (ø)`
tofu/geom/_core_optics.py	`18.52% <18.52%> (ø)`
tofu/geom/_core.py	`63.45% <30%> (-0.01%)`	⬇️
tofu/data/_spectrafit2d.py	`4.79% <4.79%> (ø)`
tofu/geom/_plot_optics.py	`6.96% <6.96%> (ø)`
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36acddd...43c9b29. Read the comment docs.

VEZINET Didier added 30 commits October 2, 2019 11:17

[Issue203] Created tf.data._spectrafit2d.py and tf.geom._core_Optics.py

3ec69af

tofu/data/_spectrafit2d.py added

872cb94

[Issue203] Advanced tofu/data/_spectrafit2d.py

fd2f26d

[Issue203] Advanced tofu/data/_spectrafit2d.py

1edd1a8

[Issue203] Advanced tofu/data/_spectrafit2d.py: included simultaneous…

376ce69

… multi ellipse fitting before re-sampled 2d fitting with known x0(y) and bsplines for y

Merge branch 'devel' into Issue203_SpectroX2DSpectraFittingNC

faac425

[Issue203] Advanced a bit herratically spectral fits...

ee04449

[Issue203] Started latex / pdf notes on ellipse intersection with pla…

c4146ac

…ne for spectral fits (Notes_Upgrades)

[Issue203] Moved notes to Notes_Upgrades/SpectroX2D

54d77e7

[Issue203] Ellipses coordinates transform ok until direct problem (No…

a6825f5

…tes) => try with crystal method

[Issue202] Advanced CrystalBragg class up to public class methods, in…

7177f0c

…cluding local plot from geom to ellipses, to be continued

[Issue202] Tested, about to merge with Issue203

59bec07

[Issue202] Advanced reverse coordinates transform in Notes

27e5416

[Issue202] Completed Notes on SpectroX2D up to reverse coordinates tr…

78e1ec3

…ansform => to be tested and validated in code

[Issue202] First version of CrystalBragg.get_braggangle_from_xixj() =…

65155bb

…> reveals probable errors in analytical calculations in Notes/SpectroX2D... to be recalculated with an alternative method

[Issue202] CrystalBragg now performing coordinates tranforms in both …

6c3b689

…directions, successfull but need to check bragg vs theta and ang_param vs epsilon (axis vs center), to test and validate

[Issue202] Renamed tofu/geom/_core_Optics.py to tofu/geom/_core_optic…

6dedc3a

…s.py

[Issue202] Added l = f(\beta) in Notes_Upgrades/SpectroX2D

d60d835

[Issue202] CrystalBragg now performs coordinates transforms in both d…

38727e8

…irections with proper parameters (bragg,angle) vs (xi, xj), tested and validated => optimize numerically or start testing on real data

[Issue202] Preparing CrystalBragg for tests with experimental data

346b58a

[Issue202] Creating tofu/geom/inputs/test_data/ for SpectroX2D (to be…

c4ff052

… moved later to units tests

[Issue202] CrystalBragg has helper routine for simple 2d plot (to be …

7396ca9

…annotated), for computing default geom parameters from bragg and curve radius, operational but results from calc_braggangle_from_xixj() not consistent: to be checked and then tested with experimental data

[Issue202] Advanced plot for fit and fitting 2d spectra function, to …

4c9be5f

…be finished and tested

[Issue202] plot of coords tranform and 2d spectral fit almost operati…

ce4650d

…onal => need to test with lambda => need to test crystal instanciation

[Issue202] Save crystal for further testing

5942ef3

[Issue202] CyrstalBragg instanciation ok up to dgeom and dmat, ArXVII…

1db9b01

… tested, surface computed, add rotation axis in dgeom and angle, add other crystals, try plotting fitted data

[Issue202] Advanced plotting

c758bad

[Issue202] Advanced CrystalBragg.plot(), to be checked

88dc5e9

[Issue202] Advanced CrystalBragg.plot() => decision to replace nIn by…

023da7a

… nout + nin property to preserve (e1, e2, nout) direct orthonormal frame, ann to update Notes_Upgrades based on this and an arbitraty frame for the crystal

[Issue202] Started sketch for Notes_Upgrades with generalized coordin…

e5a217b

…ates

VEZINET Didier and others added 18 commits October 31, 2019 18:18

[Issue202] Advance on spectralfitting => write toolbox in _spectralfi…

236d735

…t2d.py and start XICS data treatment in separate project, using tofu

[merge] merge with devel (lost py2.7 support)

0795ede

Merge remote-tracking branch 'origin/devel' into Issue202_SpectroX2DC…

32ed94b

…rystal

[Issue202] Added sep=None keyword arg to CrystalBragg.__init__() for …

9b9218b

…consistency with other classes and retor-compatibility

[Issue202] Moving back _spectralfit2d.py to tofu/data and starting pa…

94d3be9

…rameterizing with lamb0 optionally forced

Merge branch 'Issue202_SpectroX2DCrystal' of https://github.com/ToFuP…

51842f2

…roject/tofu into Issue202_SpectroX2DCrystal

Merge remote-tracking branch 'origin/devel' into Issue202_SpectroX2DC…

9351c27

…rystal

[Issue202] Advanced spectrum fit 1d

d8984c1

[Issue202] Advancing on spectralfit2d

bffe1ae

[Issue202] Advanced 2d fitting => use curve_fit with Bsplines and pro…

611dd14

…vide jacobian using BSplines.basis_element()

[Issue202] CrystalBragg.plot_datavs_fit2d() operational using scipy.l…

a52bb12

…east_squares(), but giving wrong results, maybe erro in jacobian or func ?

[Issue202] Debugging Convergence of algo using figures on fraction of…

2b30cff

… data (choose indices)

[Issue202] 2d fit operational but still slow and lacks accuracy => si…

96f47b6

…gma and delta common to same-ion lines + re-sample on less points using 2d Bsplines + adjust geometry + write same functions for 1d and 2d

[Issue202] Advanced new fitting routines for spectral 1d and 2d, base…

fea848c

…d on dlines and grouped by ions for sigma/dlamb, to be continued

[Issue202] Saving before switching to Jack Hare's issue #248

185b7c4

[Issue202] Advanced get_x0_bounds() from dlines in tf.data._spectralf…

c29d486

…it2d.py

Merge branch 'devel' into Issue202_SpectroX2DCrystal

9d8e582

[Issue202] Just making sure tofu is stable to merge this non-finalize…

806dbc9

…d branch into devel for release 1.4.2

Didou09 added geom - improve New usage data - improve labels Nov 20, 2019

Didou09 self-assigned this Nov 20, 2019

[Issue202] PEP8 Compliance 1

0dd876b

Didou09 added 2 commits November 20, 2019 15:52

Merge branch 'devel' into Issue202_SpectroX2DCrystal

43c9b29

Merge branch 'devel' into Issue202_SpectroX2DCrystal

8ad363d

Didou09 merged commit 4c43aed into devel Nov 20, 2019

This was referenced Nov 20, 2019

Preparing 1.4.2 #266

Merged

Spectro X 2D - crystal #202

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue202 spectro x2 d crystal#267

Issue202 spectro x2 d crystal#267
Didou09 merged 59 commits intodevelfrom
Issue202_SpectroX2DCrystal

Didou09 commented Nov 20, 2019 •

edited

Loading

Uh oh!

pep8speaks commented Nov 20, 2019 •

edited

Loading

Uh oh!

codecov-io commented Nov 20, 2019 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Didou09 commented Nov 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Main changes

Uh oh!

pep8speaks commented Nov 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comment last updated at 2019-11-20 15:11:00 UTC

Uh oh!

codecov-io commented Nov 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Didou09 commented Nov 20, 2019 •

edited

Loading

pep8speaks commented Nov 20, 2019 •

edited

Loading

codecov-io commented Nov 20, 2019 •

edited

Loading