Skip to content

[enhancement] took out the word error from warning#270

Merged
Didou09 merged 1 commit intomasterfrom
devel
Nov 21, 2019
Merged

[enhancement] took out the word error from warning#270
Didou09 merged 1 commit intomasterfrom
devel

Conversation

@lasofivec
Copy link
Copy Markdown
Collaborator

When an optional package is not found, the warning message used to include the word "error" which I think lead the users to confusion.
(pep8 tweaks)

@lasofivec lasofivec requested a review from Didou09 November 21, 2019 10:12
@lasofivec lasofivec self-assigned this Nov 21, 2019
@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 21, 2019

Codecov Report

Merging #270 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #270   +/-   ##
=======================================
  Coverage   41.46%   41.46%           
=======================================
  Files          79       79           
  Lines       23228    23228           
=======================================
  Hits         9632     9632           
  Misses      13596    13596
Impacted Files Coverage Δ
tofu/__init__.py 93.93% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57fd749...2d1154a. Read the comment docs.

@Didou09 Didou09 merged commit 5e2f800 into master Nov 21, 2019
@Didou09 Didou09 mentioned this pull request Jan 30, 2020
@Didou09 Didou09 mentioned this pull request Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants