Skip to content

[Issue215] fixed#279

Merged
lasofivec merged 6 commits intodevelfrom
Issue215_Interp_pts2profileWithInputTime
Nov 25, 2019
Merged

[Issue215] fixed#279
lasofivec merged 6 commits intodevelfrom
Issue215_Interp_pts2profileWithInputTime

Conversation

@Didou09
Copy link
Copy Markdown
Member

@Didou09 Didou09 commented Nov 22, 2019

Main changes:

Fixed interpolation bug, original quantity was called with wrong time index, fixed in all versions of interpolating function

Minimal working example (requires imas2tofu):

In [1]: import tofu as tf
...: shot = 54719
...: multi = tf.imas2tofu.MultiIDSLoader(shot=shot,
...: ids=['wall', 'pulse_schedule', 'soft_x_rays', 'equilibrium'])
...: sxr_data = multi.to_Data('soft_x_rays', plot=False)
...: sxr_cam = sxr_data.lCam[0]
...: sxr_cam.set_dsino([2.4, 0])
...: sxr_pts = sxr_cam.dsino['pts']
...: sxr_plasma = multi.to_Plasma2D()
...: rhopn_all = sxr_plasma.interp_pts2profile(sxr_pts, quant='equilibrium.2drhopn')
...: rhopn = sxr_plasma.interp_pts2profile(sxr_pts, quant='equilibrium.2drhopn', t=np.r_[rhopn_all[1][10]])
In [2]: np.allclose(rhopn[0], rhopn_all[0])
Out[2]: True

Issues fixed:

Fixes, in devel, issue #215

… wrong time index, fixed in all versions of interpolating function
@pep8speaks
Copy link
Copy Markdown

pep8speaks commented Nov 22, 2019

Hello @Didou09! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-11-22 19:54:15 UTC

@Didou09 Didou09 requested a review from lasofivec November 22, 2019 17:10
@Didou09 Didou09 self-assigned this Nov 22, 2019
@Didou09
Copy link
Copy Markdown
Member Author

Didou09 commented Nov 22, 2019

I'll finish the PEP8 compliance this evening

@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 22, 2019

Codecov Report

Merging #279 into devel will not change coverage.
The diff coverage is 4%.

Impacted file tree graph

@@           Coverage Diff           @@
##            devel     #279   +/-   ##
=======================================
  Coverage   41.46%   41.46%           
=======================================
  Files          79       79           
  Lines       23228    23228           
=======================================
  Hits         9632     9632           
  Misses      13596    13596
Impacted Files Coverage Δ
tofu/data/_comp.py 20.39% <0%> (ø) ⬆️
tofu/version.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccaeae2...dc8b1ae. Read the comment docs.

@Didou09
Copy link
Copy Markdown
Member Author

Didou09 commented Nov 22, 2019

Good for merging when you're ok wit the review :-)

@lasofivec lasofivec merged commit 52a3af1 into devel Nov 25, 2019
@lasofivec lasofivec deleted the Issue215_Interp_pts2profileWithInputTime branch November 25, 2019 00:09
@Didou09 Didou09 mentioned this pull request Jan 30, 2020
@Didou09 Didou09 mentioned this pull request Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants