Merged
Conversation
… wrong time index, fixed in all versions of interpolating function
Member
Author
|
I'll finish the PEP8 compliance this evening |
Codecov Report
@@ Coverage Diff @@
## devel #279 +/- ##
=======================================
Coverage 41.46% 41.46%
=======================================
Files 79 79
Lines 23228 23228
=======================================
Hits 9632 9632
Misses 13596 13596
Continue to review full report at Codecov.
|
Member
Author
|
Good for merging when you're ok wit the review :-) |
lasofivec
approved these changes
Nov 25, 2019
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes:
Fixed interpolation bug, original quantity was called with wrong time index, fixed in all versions of interpolating function
Minimal working example (requires imas2tofu):
In [1]: import tofu as tf
...: shot = 54719
...: multi = tf.imas2tofu.MultiIDSLoader(shot=shot,
...: ids=['wall', 'pulse_schedule', 'soft_x_rays', 'equilibrium'])
...: sxr_data = multi.to_Data('soft_x_rays', plot=False)
...: sxr_cam = sxr_data.lCam[0]
...: sxr_cam.set_dsino([2.4, 0])
...: sxr_pts = sxr_cam.dsino['pts']
...: sxr_plasma = multi.to_Plasma2D()
...: rhopn_all = sxr_plasma.interp_pts2profile(sxr_pts, quant='equilibrium.2drhopn')
...: rhopn = sxr_plasma.interp_pts2profile(sxr_pts, quant='equilibrium.2drhopn', t=np.r_[rhopn_all[1][10]])
In [2]: np.allclose(rhopn[0], rhopn_all[0])
Out[2]: True
Issues fixed:
Fixes, in devel, issue #215