Skip to content

Issue281 new default configs#282

Merged
lasofivec merged 3 commits intodevelfrom
Issue281_NewDefaultConfigs
Nov 26, 2019
Merged

Issue281 new default configs#282
lasofivec merged 3 commits intodevelfrom
Issue281_NewDefaultConfigs

Conversation

@Didou09
Copy link
Copy Markdown
Member

@Didou09 Didou09 commented Nov 26, 2019

Main changes:

  • Added backup npz containing approximate geometry of some other tokamaks
  • Added default config for JET with associated vessel saved as txt

tofu_issues281_JET

Issues:

Start addressing issue #281 (first step)

@Didou09 Didou09 requested a review from lasofivec November 26, 2019 14:26
@Didou09 Didou09 self-assigned this Nov 26, 2019
@pep8speaks
Copy link
Copy Markdown

Hello @Didou09! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 31:5: E301 expected 1 blank line, found 0
Line 34:5: E301 expected 1 blank line, found 0
Line 52:1: E402 module level import not at top of file

@Didou09 Didou09 changed the base branch from master to devel November 26, 2019 14:26
@Didou09 Didou09 mentioned this pull request Nov 26, 2019
@Didou09
Copy link
Copy Markdown
Member Author

Didou09 commented Nov 26, 2019

Not paying attention to PEP8 in setup.py because that file will probably change very soon after PR #275 and installation-pip-related issues

@lasofivec lasofivec merged commit 18aae81 into devel Nov 26, 2019
@lasofivec lasofivec deleted the Issue281_NewDefaultConfigs branch November 26, 2019 15:33
@Didou09 Didou09 restored the Issue281_NewDefaultConfigs branch November 26, 2019 15:43
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #282 into devel will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel     #282      +/-   ##
==========================================
+ Coverage   41.46%   41.46%   +<.01%     
==========================================
  Files          79       79              
  Lines       23228    23229       +1     
==========================================
+ Hits         9632     9633       +1     
  Misses      13596    13596
Impacted Files Coverage Δ
tofu/version.py 100% <100%> (ø) ⬆️
tofu/geom/utils.py 43.21% <100%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52a3af1...0ce1000. Read the comment docs.

@Didou09 Didou09 mentioned this pull request Jan 30, 2020
@Didou09 Didou09 mentioned this pull request Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants