Skip to content

Fix issue295#296

Merged
Didou09 merged 2 commits intoToFuProject:develfrom
flothesof:fix_issue295
Nov 28, 2019
Merged

Fix issue295#296
Didou09 merged 2 commits intoToFuProject:develfrom
flothesof:fix_issue295

Conversation

@flothesof
Copy link
Copy Markdown
Contributor

Fixes #295.

@pep8speaks
Copy link
Copy Markdown

pep8speaks commented Nov 27, 2019

Hello @flothesof! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-11-27 16:50:59 UTC

@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 27, 2019

Codecov Report

Merging #296 into devel will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel     #296      +/-   ##
==========================================
- Coverage   41.05%   41.04%   -0.02%     
==========================================
  Files          79       79              
  Lines       23468    23464       -4     
==========================================
- Hits         9634     9630       -4     
  Misses      13834    13834
Impacted Files Coverage Δ
tofu/tests/tests09_tutorials/tests01_runall.py 64.04% <100%> (-1.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ac9eee...a22d50a. Read the comment docs.

Copy link
Copy Markdown
Member

@Didou09 Didou09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please correct the path _TFROOT (not equivalent to the original)
  • Other changes are related to my review of PR #294 (i.e.: not sure moving updateversion in setup.py is a good idea)

Comment thread tofu/tests/tests09_tutorials/tests01_runall.py Outdated
Comment thread tofu/tests/tests09_tutorials/tests01_runall.py
@flothesof
Copy link
Copy Markdown
Contributor Author

I cleaned the history of this PR to just fix the unit test.

@Didou09 Didou09 merged commit f69490d into ToFuProject:devel Nov 28, 2019
@Didou09 Didou09 mentioned this pull request Nov 28, 2019
@Didou09 Didou09 mentioned this pull request Jan 30, 2020
@Didou09 Didou09 mentioned this pull request Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants