Skip to content

New tutorial on builtin configs#297

Merged
lasofivec merged 2 commits intoToFuProject:develfrom
flothesof:new_tutorial_on_builtin_configs
Nov 27, 2019
Merged

New tutorial on builtin configs#297
lasofivec merged 2 commits intoToFuProject:develfrom
flothesof:new_tutorial_on_builtin_configs

Conversation

@flothesof
Copy link
Copy Markdown
Contributor

I created a very short tutorial covering loading ITER, WEST and JET configs, as discussed today.

@pep8speaks
Copy link
Copy Markdown

Hello @flothesof! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 5:80: E501 line too long (87 > 79 characters)

Line 5:80: E501 line too long (94 > 79 characters)
Line 14:80: E501 line too long (101 > 79 characters)
Line 16:80: E501 line too long (104 > 79 characters)
Line 17:80: E501 line too long (109 > 79 characters)
Line 24:80: E501 line too long (93 > 79 characters)
Line 30:80: E501 line too long (110 > 79 characters)
Line 33:1: E402 module level import not at top of file
Line 38:18: W292 no newline at end of file

@Didou09 Didou09 requested review from Didou09 and lasofivec November 27, 2019 16:33
Copy link
Copy Markdown
Member

@Didou09 Didou09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me :-)


This is a tutorial that aims to get a new user a little familiar with tofu's
structure.
This is a tutorial that aims to get a new user a little familiar with tofu's structure.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think PEP8 will complain on line length, but it's no big deal

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as Didier.

@Didou09
Copy link
Copy Markdown
Member

Didou09 commented Nov 27, 2019

I think we can agree to be flexible on PEP8 'line too long' for tutorials because this will show up mostly in a html and not really in a IDE.
What do you think @lasofivec ?
I think we can merge this one
I'll issue a release alpha 4 afterwards


This is a tutorial that aims to get a new user a little familiar with tofu's
structure.
This is a tutorial that aims to get a new user a little familiar with tofu's structure.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as Didier.

@lasofivec lasofivec merged commit 42cc752 into ToFuProject:devel Nov 27, 2019
@Didou09 Didou09 mentioned this pull request Nov 27, 2019
@Didou09 Didou09 mentioned this pull request Jan 30, 2020
@Didou09 Didou09 mentioned this pull request Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants