Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions _updateversion.py
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
#!/usr/bin/env/python
# coding=utf-8

import sys
import os
import subprocess

_HERE = os.path.join(os.path.abspath(os.path.dirname(__file__)),'tofu')
_HERE = os.path.abspath(os.path.dirname(__file__))

def updateversion(path=_HERE):
# Fetch version from git tags, and write to version.py
# Also, when git is not available (PyPi package), use stored version.py
version_py = os.path.join(path,"version.py")
version_py = os.path.join(path, 'tofu', 'version.py')
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is independent form the issue right ?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, just making it cleaner :-)

try:
version_git = subprocess.check_output(["git",
"describe"]).rstrip().decode()
Expand Down
27 changes: 25 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,10 @@
from Cython.Distutils import build_ext
import numpy as np
# ...
import _updateversion as up
# Remove _updateversion import due to build-time dependency
# => updateversion defined in here for commodity
# => find a cleaner solution later
# import _updateversion as up
# ... for `clean` command
from distutils.command.clean import clean as Clean

Expand Down Expand Up @@ -143,6 +146,26 @@ def check_for_openmp(cc_var):

# == Getting tofu version =====================================================
_HERE = os.path.abspath(os.path.dirname(__file__))


def updateversion(path=_HERE):
# Fetch version from git tags, and write to version.py
# Also, when git is not available (PyPi package), use stored version.py
version_py = os.path.join(path, 'tofu', 'version.py')
try:
version_git = subprocess.check_output(["git",
"describe"]).rstrip().decode()
except Exception as err:
with open(version_py, 'r') as fh:
version_git = fh.read().strip().split("=")[-1].replace("'", '')
version_git = version_git.lower().replace('v', '')

version_msg = "# Do not edit, pipeline versioning governed by git tags!"
with open(version_py, "w") as fh:
msg = "{0}__version__ = '{1}'{0}".format(os.linesep, version_git)
fh.write(version_msg + msg)
return version_git

def get_version_tofu(path=_HERE):

# Try from git
Expand All @@ -163,7 +186,7 @@ def get_version_tofu(path=_HERE):
.decode()
)
if git_branch in ["master"]:
version_tofu = up.updateversion(os.path.join(path, "tofu"))
version_tofu = updateversion(os.path.join(path, "tofu"))
else:
isgit = False
except Exception:
Expand Down
2 changes: 1 addition & 1 deletion tofu/version.py
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
# Do not edit, pipeline versioning governed by git tags!
__version__ = '1.4.2-a4'
__version__ = '1.4.2-a4-5-g9b404aa'