Merged
Conversation
…updateversion.py also
Member
Author
|
Does seem to solve the problem, I could build a sdist locally and install it with pip on a fresh environment :-) |
Codecov Report
@@ Coverage Diff @@
## devel #299 +/- ##
=======================================
Coverage 41.04% 41.04%
=======================================
Files 79 79
Lines 23464 23464
=======================================
Hits 9630 9630
Misses 13834 13834
Continue to review full report at Codecov.
|
lasofivec
approved these changes
Nov 28, 2019
| # Fetch version from git tags, and write to version.py | ||
| # Also, when git is not available (PyPi package), use stored version.py | ||
| version_py = os.path.join(path,"version.py") | ||
| version_py = os.path.join(path, 'tofu', 'version.py') |
Collaborator
There was a problem hiding this comment.
this change is independent form the issue right ?
Member
Author
There was a problem hiding this comment.
Yes, just making it cleaner :-)
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfix by defining updateversion in setup.py and keeping _updateversion.py also
Fixes, in devel, Issue #292