Skip to content

Enhancement for better deployment#306

Closed
lasofivec wants to merge 16 commits intodevelfrom
pypi-depoloyment
Closed

Enhancement for better deployment#306
lasofivec wants to merge 16 commits intodevelfrom
pypi-depoloyment

Conversation

@lasofivec
Copy link
Copy Markdown
Collaborator

  • Created a matrix for travis testing: now on mac, linux (trusty and xenial)
  • Deployment only on master branch
  • Deployment of wheel package if on mac
  • Added skip_existing so that all build pass always
  • Added possibility to test deployment (using source distribution only) if push to test-deploy branch.

Warning: an account in test.pypi has to be created

@lasofivec lasofivec self-assigned this Nov 28, 2019
Comment thread .travis.yml
- '3.7-dev'

git:
depth: 200
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't go back to any old version of git so no need for this line

Comment thread .travis.yml
language: python
python:
- '3.6'
- '3.7-dev'
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.7 version now is available

Comment thread .travis.yml
- conda install tofu --use-local
- if [[ "$TRAVIS_PYTHON_VERSION" == "3.7" ]]; then export VADD="py37";
else export VADD="py36"; fi
- wget "$REPO" -O miniconda.sh
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change here since we created an environmental variable for the source of the conda repo

Comment thread .travis.yml
on:
tags: true
all_branches: true
branch: master
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to deploy for all branches only master

# Only need to change these two variables
PKG_NAME=tofu
USER=ToFuProject
OS=linux-64
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now this is was created in .travis.yml

Comment thread conda_recipe/meta.yaml Outdated
build:
script_env:
# - REV
- OS
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will use the variable from .travis.yml

Comment thread conda_recipe/meta.yaml
build:
- python
- setuptools
- setuptools >=40.8.0
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated dependency

Comment thread .travis.yml
branch: master
password:
secure: JNEDTDJVx/2fXNfHntNQ99iDRNuQ4uB3y+DBWVIBycCT95+UCb36YPtKzmruEk/UUS29Xgq4IYCGdfCSWE9smKqG8tV1PcHiw705m+AzcpKy77YtzbVECFBxqY4W36O2pHrkwEUzP/7acjFwNsnUFzArqEzsBJ+KdLaa4OPHJXCh30GA0GyqlrXYbBKG+DA9hX5vtsGo4C6w9noALYF3fS7pKPiI6ipKFnAlzGgHQ7Ke0uQME8N3IAFhmh+Z5xMtIIDWxlnqv+KszdG4DIaGV/W6NIJNAbRhzkqUd+Chu6LoPAd/XkHDTeirR/MBkNUc5UcRJxRnP9rUTRo1gCO/buTYuNRgFkMvqhV5a033+x9edWgtUiKNJIMPLXOxe0RJvc5GWji+Co77HtHxRmGRM2rnYqWMtZeYZlFbUdvHu/8jf0d6I8jyUgAoJYdlMA2u/ipENP3S6by4epE9qycUPXiIVh6r3DZbf3vPTMFvTZYAjBrA0NOzihv1xgcXwemmNUFOQSpe0io4UcFxtS9lLMo+30UMQjCHSnbEVM3zSlZmbMOKpkVOlKlt8Lz5NxwVgWtu9FuW2pGukLtE8AWbqvY9urXAPZCQqZlOIklIjJQIqOITnuw9LEV09cgvPHXfdvNni3ldbMlIQ89zryM6dYvhYryTiEZGK4JDR3wAKJA=
- provider: pypi
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I have created an account on test.pipy.org

Copy link
Copy Markdown
Member

@Didou09 Didou09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good initiative !

  • One question on REV (see below)
  • Tests on Travis are passing for 3 builds and failing for 3 others:
    • Linux 3.7 : any idea why ?
    • Mac 3.6 and 3.7 : apt-get is not valid for Mac environment (maybe create envionment-specific scripts and call them ?)

The rest seems fine,
Good job !

Comment thread conda_recipe/meta.yaml
@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 1, 2019

Codecov Report

Merging #306 into devel will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##            devel     #306   +/-   ##
=======================================
  Coverage   41.04%   41.04%           
=======================================
  Files          79       79           
  Lines       23464    23464           
=======================================
  Hits         9630     9630           
  Misses      13834    13834
Impacted Files Coverage Δ
tofu/version.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c84559b...7ceedca. Read the comment docs.

Copy link
Copy Markdown
Member

@Didou09 Didou09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me, but te travis builds are not passing yet (failing at deployement apparently)

Comment thread .travis.yml
language: generic
env:
- REPO=https://repo.anaconda.com/miniconda/Miniconda3-latest-MacOSX-x86_64.sh
- TRAVIS_PYTHON_VERSION=3.7
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable TRAVIS_PYTHON_VERSION is not defined in all cases, is it normal ?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it is defined when it's the default platform language. However on Mac it is not possible to define a job with default language "python" (thus the language: generic).
See for example:

https://docs.travis-ci.com/user/multi-os/#python-example-unsupported-languages

Comment thread .travis.yml
@Didou09 Didou09 self-requested a review December 2, 2019 09:27
Copy link
Copy Markdown
Member

@Didou09 Didou09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me when unit tests are passing

@lasofivec
Copy link
Copy Markdown
Collaborator Author

all tests are passing with this branch ;)
However i'm testing the deployment to test-pypi, to be sure the deployment with master will work. I will update this PR when deployment to test-pypi is working.

@lasofivec
Copy link
Copy Markdown
Collaborator Author

Replaced by #328

@lasofivec lasofivec closed this Jan 21, 2020
@lasofivec lasofivec deleted the pypi-depoloyment branch January 21, 2020 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants