Conversation
|
Hello @lasofivec! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-01-21 15:47:21 UTC |
Didou09
left a comment
Didou09
left a comment
There was a problem hiding this comment.
Good for me, but:
- It looks like the deployment to anaconda is not done in .travis.yaml anymore, or am I mistaken ?
- There is more explicit error message for the volume computation error, which is good, but has the error itself been corrected somewhere ? (another branch ?)
| on: | ||
| tags: true | ||
| branch: master | ||
| skip_cleanup: true |
There was a problem hiding this comment.
anaconda deployment being done here
| with open(version_py,'r') as fh: | ||
| version_git = fh.read().strip().split("=")[-1].replace("'",'') | ||
| version_git = version_git.lower().replace('v','') | ||
| except subprocess.CalledProcessError: |
There was a problem hiding this comment.
catching right exception
| .decode() | ||
| ) | ||
| if git_branch in ["master"]: | ||
| if git_branch in ["master", "deploy-test"]: |
There was a problem hiding this comment.
updating version on both deployment branches
Codecov Report
@@ Coverage Diff @@
## devel #328 +/- ##
==========================================
- Coverage 40.23% 40.04% -0.19%
==========================================
Files 79 79
Lines 23993 24111 +118
==========================================
+ Hits 9653 9656 +3
- Misses 14340 14455 +115
Continue to review full report at Codecov.
|
|
I'll let you decide if you want to keep the branch |
|
It's a matter of "taste" I guess. Same as with "new-doc". We can erase them, and recreate them when needed (ie. before testing a deployment and when updating the documentation). Branches are bit like "pointers" to commits, so I don't see a problem with erasing them, nor with keeping them (except for having too many active+stale branches). |
4 participants
Created a matrix for travis testing:
deploy-testbranch.