[ #314 ] fixed bug on mac coming from modulo with negative values#323
Merged
[ #314 ] fixed bug on mac coming from modulo with negative values#323
Conversation
Didou09
reviewed
Jan 9, 2020
Member
Didou09
left a comment
Didou09
left a comment
There was a problem hiding this comment.
Good for me when tests are passing
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #314 was coming from a modulo operation with
@cython.cdivision(True), it gives the wrong result with negative values and cdef defined variables.Since this flags accelerates the code overall, and that the modulo operand was only being use for a -/+1 operation on a integer in [0,npts[ that should stay in [0,npts[, I decided to add one if test that should not slow down the function.