Skip to content

Feature nstx#309

Merged
lasofivec merged 3 commits intoToFuProject:develfrom
flothesof:feature_nstx
Dec 2, 2019
Merged

Feature nstx#309
lasofivec merged 3 commits intoToFuProject:develfrom
flothesof:feature_nstx

Conversation

@flothesof
Copy link
Copy Markdown
Contributor

I've just added the geometry for NSTX based on https://iopscience.iop.org/article/10.1088/0029-5515/52/5/054012/meta
Adds the geometry as well as an entry in the table of configurations.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #309 into devel will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel     #309      +/-   ##
==========================================
+ Coverage   41.02%   41.02%   +<.01%     
==========================================
  Files          79       79              
  Lines       23477    23478       +1     
==========================================
+ Hits         9632     9633       +1     
  Misses      13845    13845
Impacted Files Coverage Δ
tofu/geom/utils.py 43.34% <100%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6065092...eb212b2. Read the comment docs.

Copy link
Copy Markdown
Member

@Didou09 Didou09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nickel pour moi !

@Didou09 Didou09 requested a review from lasofivec December 2, 2019 16:32
@Didou09 Didou09 self-assigned this Dec 2, 2019
@lasofivec lasofivec merged commit 2d9b183 into ToFuProject:devel Dec 2, 2019
@lasofivec
Copy link
Copy Markdown
Collaborator

Do you think we could add the obtained 2D cam image as an example ?

@Didou09
Copy link
Copy Markdown
Member

Didou09 commented Dec 2, 2019

We probably should,
At some point, when we have a bit more tokamaks, we'll probably plot all of them in a common figure to give an idea of their respective scale and with their associated plot_touch() images, to give a nice overview of all of them

@Didou09 Didou09 mentioned this pull request Jan 30, 2020
@Didou09 Didou09 mentioned this pull request Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants