Skip to content

Quick fix: wrong path in update version#315

Merged
Didou09 merged 1 commit intodevelfrom
qf-update-version
Dec 4, 2019
Merged

Quick fix: wrong path in update version#315
Didou09 merged 1 commit intodevelfrom
qf-update-version

Conversation

@lasofivec
Copy link
Copy Markdown
Collaborator

@lasofivec lasofivec commented Dec 4, 2019

the path to the file version had twice the directory "tofu" appended:

Once here (in the function)

tofu/setup.py

Line 154 in c25c76c

version_py = os.path.join(path, 'tofu', 'version.py')

A second time here (at call time):

tofu/setup.py

Line 189 in 0bfdf2b

version_tofu = updateversion(os.path.join(path, "tofu"))

so it was working for the version.py file in $TOFU_DIR/tofu/tofu/

@lasofivec lasofivec self-assigned this Dec 4, 2019
@lasofivec lasofivec added the bug label Dec 4, 2019
@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 4, 2019

Codecov Report

Merging #315 into devel will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            devel     #315   +/-   ##
=======================================
  Coverage   41.02%   41.02%           
=======================================
  Files          79       79           
  Lines       23478    23478           
=======================================
  Hits         9633     9633           
  Misses      13845    13845

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bfdf2b...bbcea75. Read the comment docs.

Copy link
Copy Markdown
Member

@Didou09 Didou09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me

@Didou09 Didou09 merged commit e0d44f3 into devel Dec 4, 2019
@lasofivec lasofivec deleted the qf-update-version branch December 4, 2019 14:13
@Didou09 Didou09 mentioned this pull request Jan 30, 2020
@Didou09 Didou09 mentioned this pull request Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants