Skip to content

[doc] updated gallery tuto: bf #329#330

Merged
Didou09 merged 4 commits intodevelfrom
new-doc
Jan 24, 2020
Merged

[doc] updated gallery tuto: bf #329#330
Didou09 merged 4 commits intodevelfrom
new-doc

Conversation

@lasofivec
Copy link
Copy Markdown
Collaborator

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 21, 2020

Codecov Report

Merging #330 into devel will decrease coverage by 0.02%.
The diff coverage is 44.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel     #330      +/-   ##
==========================================
- Coverage   40.04%   40.02%   -0.03%     
==========================================
  Files          79       79              
  Lines       24111    24132      +21     
==========================================
+ Hits         9656     9659       +3     
- Misses      14455    14473      +18
Impacted Files Coverage Δ
tofu/version.py 100% <100%> (ø) ⬆️
tofu/geom/_comp.py 59.91% <42.85%> (-0.61%) ⬇️
tofu/geom/_core.py 63.08% <43.47%> (-0.12%) ⬇️
tofu/geom/utils.py 42.03% <44.44%> (-0.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfeeec9...2548b06. Read the comment docs.

Copy link
Copy Markdown
Member

@Didou09 Didou09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good, however, I would leave this PR open until we have fixed Issue #331
Because then we'll be able to add ASDEX Upgrade too in the tutorial :-)

Until then, the png image for NSTX does not seem to show (at least on my web browser)

@lasofivec
Copy link
Copy Markdown
Collaborator Author

Very good, however, I would leave this PR open until we have fixed Issue #331
Because then we'll be able to add ASDEX Upgrade too in the tutorial :-)

Fine by me :)

Until then, the png image for NSTX does not seem to show (at least on my web browser)

Fixed !

@Didou09
Copy link
Copy Markdown
Member

Didou09 commented Jan 24, 2020

Very good, however, I would leave this PR open until we have fixed Issue #331
Because then we'll be able to add ASDEX Upgrade too in the tutorial :-)

Fine by me :)

Now that PR #333 has been merged, could you also add AUG in the tutorial ? :-)

@lasofivec
Copy link
Copy Markdown
Collaborator Author

done

@Didou09
Copy link
Copy Markdown
Member

Didou09 commented Jan 24, 2020

Thanks !
I'm merging, ready for a release on Monday ?

@Didou09 Didou09 merged commit 822c9da into devel Jan 24, 2020
@Didou09 Didou09 mentioned this pull request Jan 30, 2020
@Didou09 Didou09 mentioned this pull request Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants